Report duraction when storing artifacts in remote-nx #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3598c22 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
I didn't realise that this repo used an old pnpm version and it updated all of the dependencies when it regenerated the lockfile. Reverting... |
|
Thanks for this! I will test this as well, but looks good to me. I will also update pnpm in another PR here 😨 |
|
Updated package manager here: #19 Feel free to pull this out of draft when you're ready @tom-sherman! |
tknickman
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #17.
This PR should allow reporting "time saved" in Vercel when using remote-nx.
Pretty sure the code is sound (assuming that I'm right in my thinking about how
duractionworks).This is in draft while I find a way to test it in our monorepo but feel free to review!