Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text center issue with Max width applied #525

Closed
anasak-dev opened this issue Jul 27, 2023 · 3 comments · Fixed by #527
Closed

Text center issue with Max width applied #525

anasak-dev opened this issue Jul 27, 2023 · 3 comments · Fixed by #527
Labels
bug Something isn't working released

Comments

@anasak-dev
Copy link

anasak-dev commented Jul 27, 2023 •
edited
Loading

Bug report

Description / Observed Behavior

When maxWidth is applied to a div and text is align centre,
the issue is the text is not exactly aligned to centre, there's empty space on right side of text
you can see in html preview (which works) and satori png (which has a bug)

Expected Behavior

I expect satori png preview to show no extra spacing and text should align centre as in html preview, since I see textAlign and maxWidth is allowed in satori

Reproduction

Reproduction link

reproduction link

HTML Preview (works)

html-render

Satori png render (spacing issue marked with yellow box)

satori-png-render
@shuding shuding added the bug Something isn't working label Aug 1, 2023
@Jackie1210
Copy link
Contributor

Jackie1210 commented Aug 10, 2023 •
edited
Loading

I not sure if it is a bug when combing max-width and letter-spacing, after i remove letter-spacing, it just looks fine. Worth to dig

@LuciNyan LuciNyan mentioned this issue Aug 10, 2023
Merged
@anasak-dev
Copy link
Author

@Jackie1210 , thanks for checking this

I deleted the letter-spacing but it was still not exactly centred but indeed its better from the previous with letter-spacing being added.

shuding pushed a commit that referenced this issue Aug 11, 2023
@LuciNyan
fix: text-align (#527)
3f598c2 
### Description

Closes: #525
@github-actions
Copy link

🎉 This issue has been resolved in version 0.10.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

sahithyandev pushed a commit to sahithyandev/satori that referenced this issue Apr 26, 2024
@LuciNyan @sahithyandev
fix: text-align (vercel#527)
c455b53 
### Description

Closes: vercel#525
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: text-align LuciNyan/satori
3 participants
@shuding @anasak-dev @Jackie1210