feat: Add cjs support #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
shuding
approved these changes
Oct 14, 2022
|
Yes, I tested the cjs build. const { default: satori } = require("satori")
console.log(satori)Unfortunately, the default import doesn't work out of the box with cjs but you can export .default in another file and have it in place of generated one. For ref on tsup regarding above: egoist/tsup#572 I will leave to decision to add that extra re-export file up to you. |
|
I think this is fine, thanks again! |
|
@shuding Thank you so much. Do you think you would be able to cut a release? |
|
@searchableguy Just got |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #190
PR adds cjs support alongside esm.
Feel free to close if this cjs support is unwarranted.