Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: gradient & support more degree unit #562

Closed
wants to merge 6 commits into from
Closed

refactor: gradient & support more degree unit #562

wants to merge 6 commits into from

Conversation

Jackie1210
Copy link
Contributor

@Jackie1210 Jackie1210 commented Oct 15, 2023 •
edited
Loading

I am working on implementing repeating-linear-gradient, but I think we should refactor logic here at first for future.

  • I made a lib css-gradient-parser since vendor we currently use is lack of tests and really hard to read and debug.
  • support turn, rad, grad in linear-gradient

Fix #581 (comment)
Fix #581 (comment)

@vercel
Copy link

vercel bot commented Oct 15, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
satori-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 22, 2024 3:35am

@Jackie1210 Jackie1210 changed the title refactor: gradient && support more degreee unit refactor: gradient & support more degreee unit Oct 15, 2023
@Jackie1210 Jackie1210 changed the title refactor: gradient & support more degreee unit refactor: gradient & support more degree unit Oct 15, 2023
@Jackie1210
Copy link
Contributor Author

Hi,@shuding!Do you have time to have a check on this PR? I have finished the repeating-linear-gradient, which I will make a PR based on this one. Thanks for your time~

@Jackie1210 Jackie1210 mentioned this pull request Oct 18, 2023
Closed
@mustafasegf
Copy link

@shuding hi there, I would love to have this feature. Can you please review this? Thanks!

@Jackie1210 Jackie1210 mentioned this pull request Jun 22, 2024
Closed
Jackie1210 and others added 6 commits June 22, 2024 11:34
@Jackie1210
refactor: gradient && support more degreee unit
9d6990c
@Jackie1210
chore: remove comment
c393032
@Jackie1210
chore: remove gradient-parser in vendor
39c19d6
@Jackie1210
chore: remove log
13c7c8c
@LuciNyan @Jackie1210
fix: should render spaces other than U+0020 when white-space: normal (
0c6351c 
vercel#557)

### Description
Should render spaces other than U+0020 when `white-space: normal`.

Before:

![image](https://github.com/vercel/satori/assets/22126563/132f9345-88ff-4ee7-8dcf-5a290a8f2ed6)

After:

![image](https://github.com/vercel/satori/assets/22126563/78d61815-7695-4b48-900b-b481d8891047)
@tehuel @Jackie1210
fix: README table (vercel#571)
c5a60ed 
small fix to display correct table border.

Before the fix (see bottom of "Mask" cell):

![screen-2](https://github.com/vercel/satori/assets/1787206/cb8cb86a-02b0-4015-b3c8-6ea3c78b33fe)

After the fix:

![screen-1](https://github.com/vercel/satori/assets/1787206/03b1a7b4-0e77-4e5b-8d71-c834f179fa0a)
@Jackie1210 Jackie1210 force-pushed the feat/repeating-linear-gradient branch from b3ab6ed to c5a60ed Compare June 22, 2024 03:34
@Jackie1210 Jackie1210 closed this Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuding shuding Awaiting requested review from shuding shuding is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error with linear-gradient
4 participants
@Jackie1210 @mustafasegf @LuciNyan @tehuel