Extend headers validation pattern (#76)

vercel · Jan 24, 2023 · 36f4b63 · 36f4b63
1 parent 9362fd2
commit 36f4b63
Show file tree

Hide file tree

Showing 2 changed files with 44 additions and 1 deletion.
diff --git a/deployment/config-static.js b/deployment/config-static.js
@@ -49,7 +49,7 @@ module.exports = {
 									type: 'string',
 									minLength: 1,
 									maxLength: 2048,
-									pattern: "^[a-zA-Z0-9_!#$%&'*+.;/:, =^`|~-]+$"
+									pattern: '^[\u0020-\u007e\u00a0-\u00ff]+$'
 								}
 							},
 							additionalProperties: false

diff --git a/test/deployment.js b/test/deployment.js
@@ -181,6 +181,28 @@ exports.test_valid_static_headers_object = () => {
 	});
 
 	assert.equal(isValid, true);
+
+	for (let i = 0x20; i <= 0xff; i++) {
+		if (i > 0x7e && i < 0xa0) {
+			continue;
+		}
+
+		const result = ajv.validate(deploymentConfigSchema, {
+			'static': {
+				headers: [
+					{
+						source: '/',
+						headers: [{
+							key: 'X-Test',
+							value: `value ${String.fromCharCode(i)}`
+						}]
+					}
+				]
+			}
+		});
+
+		assert.equal(result, true, `Failed to validate for char: 0x${i.toString(16)}`);
+	}
 };
 
 exports.test_invalid_static_headers_object = () => {
@@ -206,6 +228,27 @@ exports.test_invalid_static_headers_object = () => {
 	});
 
 	assert.equal(isValid, false);
+
+	// Use 256 to go above 0xff
+	for (let i = 0; i <= 256; i++) {
+		if ((i >= 0x20 && i <= 0x7e) || (i >= 0xa0 && i <= 0xff)) {
+			continue;
+		}
+
+		const result = ajv.validate(deploymentConfigSchema, {
+			'static': {
+				headers: {
+					source: '/',
+					headers: [{
+						key: 'X-Test',
+						value: `value ${String.fromCharCode(i)}`
+					}]
+				}
+			}
+		});
+
+		assert.equal(result, false, `Failed to error for char: 0x${i.toString(16)}`);
+	}
 };
 
 exports.test_valid_static_object_trailing_slash = () => {