Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle ETag and If-None-Match #39

Merged
merged 6 commits into from
Jul 25, 2018
Merged

Handle ETag and If-None-Match #39

merged 6 commits into from
Jul 25, 2018

Conversation

leo
Copy link
Contributor

@leo leo commented Jul 25, 2018

This adds native support for 304 responses for any path in the case that:

  • A ETag header was set for that path
  • A request comes in to that path with If-None-Match matching the previously sent ETag

Only if both are true, the 304 response will occur.

@leo leo added the enhancement New feature or request label Jul 25, 2018
@codecov
Copy link

codecov bot commented Jul 25, 2018

Codecov Report

Merging #39 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #39   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines         285    289    +4     
=====================================
+ Hits          285    289    +4
Impacted Files Coverage Δ
src/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afc1387...b30f450. Read the comment docs.

@leo leo requested a review from rauchg July 25, 2018 18:19
@leo leo merged commit d7e026b into master Jul 25, 2018
@leo leo deleted the etag branch July 25, 2018 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants