Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix missing zero in one day cache number #255

Merged
merged 1 commit into from
Jul 24, 2017
Merged

fix missing zero in one day cache number #255

merged 1 commit into from
Jul 24, 2017

Conversation

albertstill
Copy link
Contributor

@albertstill albertstill commented Jul 23, 2017 •
edited
Loading

@albertstill
fix missing zero in one day cache number
d631693 
86400000 milliseconds is 1 day
@leo
Copy link
Contributor

leo commented Jul 23, 2017

Thank you! But the MDN documentation states that it should be seconds.

@leo leo closed this Jul 23, 2017
@albertstill
Copy link
Contributor Author

I know the Cache-Control HTTP header is in seconds, but this is a send options object, which is in milliseconds. Right now it's missing a single zero, so it equates to 2.4 hours, and your API is saying it should be 24 hours.

@leo
Copy link
Contributor

leo commented Jul 24, 2017 •
edited
Loading

Oh, that's a very confusing API of theirs. Then let's merge this! Thanks 😊

@leo leo reopened this Jul 24, 2017
@leo leo merged commit 8edb2c6 into vercel:master Jul 24, 2017
@leo
Copy link
Contributor

leo commented Jul 24, 2017

Released!

@albertstill
Copy link
Contributor Author

cool thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@albertstill @leo