Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[firewall] return errors in diagnostics #226

Merged
merged 1 commit into from
Oct 27, 2024
Merged

[firewall] return errors in diagnostics #226

merged 1 commit into from
Oct 27, 2024

Conversation

sueplex
Copy link
Contributor

@sueplex sueplex commented Oct 26, 2024

Exiting early after receiving an error and appending to diagnostics skips the followign line to append and early return after checking errors

@dglsparsons dglsparsons merged commit c942f2e into main Oct 27, 2024
9 checks passed
@dglsparsons dglsparsons deleted the sa/firewall-config-errors branch October 27, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dglsparsons dglsparsons dglsparsons approved these changes

@craigandrews craigandrews Awaiting requested review from craigandrews craigandrews is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sueplex @dglsparsons