Skip to content

Commit

Permalink
no longer build arm64 go builds (#3838)
Browse files Browse the repository at this point in the history
> 🚨 note: I am assuming here that npm is intelligent enough to offer up the x86 package automatically, but there may be more we need to do here..

Rust's only toolchain on windows arm is msvc, which complicates linking now that we have the rust sandwich, as go uses gnu. Rather than attempt to get go building with msvc, we can instead just rely on windows' x86 emulation and publish one set of binaries for that platform until go is removed from our toolchain altogether.
  • Loading branch information
arlyon authored Feb 21, 2023
1 parent c4a066b commit cda81f6
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 4 deletions.
11 changes: 8 additions & 3 deletions .github/workflows/turborepo-release-step-3.yml
Original file line number Diff line number Diff line change
Expand Up @@ -141,12 +141,17 @@ jobs:
mv go-artifacts/turbo-go-cross-${{ inputs.release_branch }}/turbo_linux_arm64/bin/* cli/dist-linux-arm64
chmod a+x cli/dist-linux-arm64/turbo
chmod a+x cli/dist-linux-arm64/go-turbo
# rust doesn't have a toolchain for arm + windows + gnu, so we just use the exe from the amd64 build
# and rely on windows' arm JITer to do the work for us. this is because the go exe cannot be build w/ msvc
cp -r go-artifacts/turbo-go-cross-${{ inputs.release_branch }}/turbo_windows_amd64_v1/bin/* cli/dist-windows-arm64
chmod a+x cli/dist-windows-arm64/turbo.exe
chmod a+x cli/dist-windows-arm64/go-turbo.exe
mv go-artifacts/turbo-go-cross-${{ inputs.release_branch }}/turbo_windows_amd64_v1/bin/* cli/dist-windows-amd64
chmod a+x cli/dist-windows-amd64/turbo.exe
chmod a+x cli/dist-windows-amd64/go-turbo.exe
mv go-artifacts/turbo-go-cross-${{ inputs.release_branch }}/turbo_windows_arm64/bin/* cli/dist-windows-arm64
chmod a+x cli/dist-windows-arm64/turbo.exe
chmod a+x cli/dist-windows-arm64/go-turbo.exe
mv go-artifacts/turbo-go-darwin-${{ inputs.release_branch }}/turbo_darwin_amd64_v1/bin/* cli/dist-darwin-amd64
chmod a+x cli/dist-darwin-amd64/turbo
chmod a+x cli/dist-darwin-amd64/go-turbo
Expand Down
1 change: 0 additions & 1 deletion cli/cross-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ builds:
targets:
- linux_arm64
- linux_amd64
- windows_arm64
- windows_amd64
overrides:
- goos: linux
Expand Down

1 comment on commit cda81f6

@vercel
Copy link

@vercel vercel bot commented on cda81f6 Feb 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.