no longer build arm64 go builds #3838
Conversation
arlyon
force-pushed
the
arlyon/windows-arm
branch
from
f8ac672 to
0162be7
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
🟢 CI successful 🟢Thanks |
There was a problem hiding this comment.
I don't have any experience in this area, but if it works, that seems good to me.
It looks like it's our postinstall script that chooses the right binary to download though. Maybe edit this to always serve the x86 build?
https://github.com/vercel/turbo/blob/564a0f0dab223fbaf2ad4a7a3a5332aa50e27eb0/packages/turbo/node-platform.js#L32-L36
There was a problem hiding this comment.
I'm almost positive we need to change our postinstall logic that resides in packages/turbo/node-platform.js to now look for the turbo-windows-64 when on arm64 instead of turbo-windows-arm64 like it does now.
We should also confirm that goreleaser release --rm-dist -f combined-shim.yml --skip-publish produces a turbo-windows-64 where "cpu": ["x64", "arm64"]
| @@ -144,9 +144,6 @@ jobs: | |||
| mv go-artifacts/turbo-go-cross-${{ inputs.release_branch }}/turbo_windows_amd64_v1/bin/* cli/dist-windows-amd64 | |||
| chmod a+x cli/dist-windows-amd64/turbo.exe | |||
| chmod a+x cli/dist-windows-amd64/go-turbo.exe | |||
| mv go-artifacts/turbo-go-cross-${{ inputs.release_branch }}/turbo_windows_arm64/bin/* cli/dist-windows-arm64 | |||
There was a problem hiding this comment.
I think we want to continue shipping a windows/arm package, since we'll eventually be building it natively in Rust. So I think maybe this ought to be
mv go-artifacts/turbo-go-cross-${{ inputs.release_branch }}/turbo_windows_amd64_v1/bin/* cli/dist-windows-arm64
And keep the following lines?
cli/combined-shim.yml
Outdated
| @@ -16,6 +16,11 @@ builds: | |||
| - arm64 | |||
| goamd64: | |||
| - v1 | |||
| ignore: | |||
There was a problem hiding this comment.
I think we still want to build the windows/arm package, it just has x86 binaries in it.
| @@ -22,7 +22,6 @@ builds: | |||
| targets: | |||
| - linux_arm64 | |||
| - linux_amd64 | |||
| - windows_arm64 | |||
There was a problem hiding this comment.
I think we can delete the overrides entry below as well.
arlyon
force-pushed
the
arlyon/windows-arm
branch
from
0162be7 to
cb462ab
Compare
arlyon
force-pushed
the
arlyon/windows-arm
branch
from
cb462ab to
c9809c5
Compare
arlyon
force-pushed
the
arlyon/windows-arm
branch
from
c9809c5 to
7b1bb93
Compare
gsoltis
added
the
pr: automerge
Rust's only toolchain on windows arm is msvc, which complicates linking now that we have the rust sandwich, as go uses gnu. Rather than attempt to get go building with msvc, we can instead just rely on windows' x86 emulation and publish one set of binaries for that platform until go is removed from our toolchain altogether.