Skip to content

Commit

Permalink
nitpicks
Browse files Browse the repository at this point in the history
  • Loading branch information
sokra committed Jul 17, 2024
1 parent 2f5f93b commit 0096afb
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 7 deletions.
6 changes: 0 additions & 6 deletions crates/turbo-tasks/src/task/function.rs
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,6 @@ macro_rules! task_fn_impl {
{
#[allow(non_snake_case)]
fn functor(&self, _this: Option<RawVc>, arg: &ConcreteTaskInput) -> Result<NativeTaskFn> {
#[allow(unused_parens)]
let ($($arg),*) = <($($arg),*) as TaskInput>::try_from_concrete(arg)?;

Check failure on line 168 in crates/turbo-tasks/src/task/function.rs

View workflow job for this annotation

GitHub Actions / Turbopack rust check

unnecessary parentheses around pattern

Check failure on line 168 in crates/turbo-tasks/src/task/function.rs

View workflow job for this annotation

GitHub Actions / Turbopack rust check

unnecessary parentheses around type

Check failure on line 168 in crates/turbo-tasks/src/task/function.rs

View workflow job for this annotation

GitHub Actions / Turbopack rust check

unnecessary parentheses around pattern

Check failure on line 168 in crates/turbo-tasks/src/task/function.rs

View workflow job for this annotation

GitHub Actions / Turbopack rust check

unnecessary parentheses around type

let task_fn = self.clone();
Expand All @@ -192,7 +191,6 @@ macro_rules! task_fn_impl {
{
#[allow(non_snake_case)]
fn functor(&self, _this: Option<RawVc>, arg: &ConcreteTaskInput) -> Result<NativeTaskFn> {
#[allow(unused_parens)]
let ($($arg),*) = <($($arg),*) as TaskInput>::try_from_concrete(arg)?;

Check failure on line 194 in crates/turbo-tasks/src/task/function.rs

View workflow job for this annotation

GitHub Actions / Turbopack rust check

unnecessary parentheses around pattern

Check failure on line 194 in crates/turbo-tasks/src/task/function.rs

View workflow job for this annotation

GitHub Actions / Turbopack rust check

unnecessary parentheses around type

Check failure on line 194 in crates/turbo-tasks/src/task/function.rs

View workflow job for this annotation

GitHub Actions / Turbopack rust check

unnecessary parentheses around pattern

Check failure on line 194 in crates/turbo-tasks/src/task/function.rs

View workflow job for this annotation

GitHub Actions / Turbopack rust check

unnecessary parentheses around type

let task_fn = self.clone();
Expand Down Expand Up @@ -222,7 +220,6 @@ macro_rules! task_fn_impl {
let task_fn = self.clone();
let recv = Vc::<Recv>::from(this.expect("Method need to have a `self` argument"));

#[allow(unused_parens)]
let ($($arg),*) = <($($arg),*) as TaskInput>::try_from_concrete(arg)?;

Check failure on line 223 in crates/turbo-tasks/src/task/function.rs

View workflow job for this annotation

GitHub Actions / Turbopack rust check

unnecessary parentheses around pattern

Check failure on line 223 in crates/turbo-tasks/src/task/function.rs

View workflow job for this annotation

GitHub Actions / Turbopack rust check

unnecessary parentheses around type

Check failure on line 223 in crates/turbo-tasks/src/task/function.rs

View workflow job for this annotation

GitHub Actions / Turbopack rust check

unnecessary parentheses around pattern

Check failure on line 223 in crates/turbo-tasks/src/task/function.rs

View workflow job for this annotation

GitHub Actions / Turbopack rust check

unnecessary parentheses around type

Ok(Box::new(move || {
Expand Down Expand Up @@ -252,7 +249,6 @@ macro_rules! task_fn_impl {
let task_fn = self.clone();
let recv = Vc::<Recv>::from(this.expect("Method need to have a `self` argument"));

#[allow(unused_parens)]
let ($($arg),*) = <($($arg),*) as TaskInput>::try_from_concrete(arg)?;

Check failure on line 252 in crates/turbo-tasks/src/task/function.rs

View workflow job for this annotation

GitHub Actions / Turbopack rust check

unnecessary parentheses around pattern

Check failure on line 252 in crates/turbo-tasks/src/task/function.rs

View workflow job for this annotation

GitHub Actions / Turbopack rust check

unnecessary parentheses around type

Check failure on line 252 in crates/turbo-tasks/src/task/function.rs

View workflow job for this annotation

GitHub Actions / Turbopack rust check

unnecessary parentheses around pattern

Check failure on line 252 in crates/turbo-tasks/src/task/function.rs

View workflow job for this annotation

GitHub Actions / Turbopack rust check

unnecessary parentheses around type

Ok(Box::new(move || {
Expand Down Expand Up @@ -294,7 +290,6 @@ macro_rules! task_fn_impl {
let task_fn = self.clone();
let recv = Vc::<Recv>::from(this.expect("Method need to have a `self` argument"));

#[allow(unused_parens)]
let ($($arg),*) = <($($arg),*) as TaskInput>::try_from_concrete(arg)?;

Check failure on line 293 in crates/turbo-tasks/src/task/function.rs

View workflow job for this annotation

GitHub Actions / Turbopack rust check

unnecessary parentheses around pattern

Check failure on line 293 in crates/turbo-tasks/src/task/function.rs

View workflow job for this annotation

GitHub Actions / Turbopack rust check

unnecessary parentheses around type

Check failure on line 293 in crates/turbo-tasks/src/task/function.rs

View workflow job for this annotation

GitHub Actions / Turbopack rust check

unnecessary parentheses around pattern

Check failure on line 293 in crates/turbo-tasks/src/task/function.rs

View workflow job for this annotation

GitHub Actions / Turbopack rust check

unnecessary parentheses around type

Ok(Box::new(move || {
Expand Down Expand Up @@ -323,7 +318,6 @@ macro_rules! task_fn_impl {
let task_fn = self.clone();
let recv = Vc::<Recv>::from(this.expect("Method need to have a `self` argument"));

#[allow(unused_parens)]
let ($($arg),*) = <($($arg),*) as TaskInput>::try_from_concrete(arg)?;

Ok(Box::new(move || {
Expand Down
2 changes: 1 addition & 1 deletion crates/turbo-tasks/src/task/task_input.rs
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,7 @@ macro_rules! tuple_impls {
};
}

// Implement `TaskInput` for all tuples of 1 to 12 elements.
// Implement `TaskInput` for all tuples of 1 to 16 elements.
tuple_impls! { A }
tuple_impls! { A B }
tuple_impls! { A B C }
Expand Down

0 comments on commit 0096afb

Please sign in to comment.