Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement FromSubTrait for ValueDebug #3769

Merged
merged 1 commit into from
Feb 13, 2023
Merged

Conversation

alexkirsz
Copy link
Contributor

This is necessary in order to pass in a SomeTraitVc to a function which expects T: ValueDebug.

@alexkirsz alexkirsz requested a review from a team as a code owner February 13, 2023 13:57
@vercel
Copy link

vercel bot commented Feb 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
turbo-site ✅ Ready (Inspect) Visit Preview Feb 13, 2023 at 1:57PM (UTC)
9 Ignored Deployments
Name Status Preview Updated
examples-basic-web ⬜️ Ignored (Inspect) Feb 13, 2023 at 1:57PM (UTC)
examples-cra-web ⬜️ Ignored (Inspect) Feb 13, 2023 at 1:57PM (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Feb 13, 2023 at 1:57PM (UTC)
examples-kitchensink-blog ⬜️ Ignored (Inspect) Feb 13, 2023 at 1:57PM (UTC)
examples-native-web ⬜️ Ignored (Inspect) Feb 13, 2023 at 1:57PM (UTC)
examples-nonmonorepo ⬜️ Ignored (Inspect) Feb 13, 2023 at 1:57PM (UTC)
examples-svelte-web ⬜️ Ignored (Inspect) Feb 13, 2023 at 1:57PM (UTC)
examples-tailwind-web ⬜️ Ignored (Inspect) Feb 13, 2023 at 1:57PM (UTC)
examples-vite-web ⬜️ Ignored (Inspect) Feb 13, 2023 at 1:57PM (UTC)

@alexkirsz alexkirsz added the pr: automerge Kodiak will merge these automatically after checks pass label Feb 13, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 13, 2023

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@kodiakhq kodiakhq bot merged commit ebc49f6 into main Feb 13, 2023
@kodiakhq kodiakhq bot deleted the alexkirsz/value-debug-sub-trait branch February 13, 2023 14:14
@github-actions
Copy link
Contributor

Benchmark for 4e4a4c7

Test Base PR % Significant %
bench_startup/Turbopack SSR/1000 modules 2161.80ms ± 4.00ms 2144.44ms ± 2.87ms -0.80% -0.17%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 9439.67µs ± 73.59µs 9647.25µs ± 59.83µs +2.20%
bench_hmr_to_commit/Turbopack RCC/1000 modules 12.06ms ± 0.19ms 12.37ms ± 0.24ms +2.60%
bench_hmr_to_commit/Turbopack RSC/1000 modules 515.56ms ± 3.98ms 510.41ms ± 2.55ms -1.00%
bench_hmr_to_commit/Turbopack SSR/1000 modules 9437.90µs ± 77.75µs 9518.48µs ± 91.99µs +0.85%
bench_hmr_to_eval/Turbopack CSR/1000 modules 8624.03µs ± 55.92µs 8580.03µs ± 120.16µs -0.51%
bench_hmr_to_eval/Turbopack RCC/1000 modules 10.80ms ± 0.22ms 11.00ms ± 0.15ms +1.87%
bench_hmr_to_eval/Turbopack SSR/1000 modules 8916.84µs ± 58.75µs 9143.23µs ± 114.57µs +2.54%
bench_hydration/Turbopack RCC/1000 modules 4239.52ms ± 10.50ms 4234.95ms ± 10.58ms -0.11%
bench_hydration/Turbopack RSC/1000 modules 3847.39ms ± 13.81ms 3871.26ms ± 22.27ms +0.62%
bench_hydration/Turbopack SSR/1000 modules 3751.20ms ± 17.90ms 3780.36ms ± 9.41ms +0.78%
bench_startup/Turbopack CSR/1000 modules 2838.05ms ± 11.62ms 2827.93ms ± 17.32ms -0.36%
bench_startup/Turbopack RCC/1000 modules 2601.18ms ± 6.35ms 2592.63ms ± 5.76ms -0.33%
bench_startup/Turbopack RSC/1000 modules 2503.09ms ± 8.83ms 2522.12ms ± 9.50ms +0.76%
bench_startup/Turbopack SSR/1000 modules 2161.80ms ± 4.00ms 2144.44ms ± 2.87ms -0.80% -0.17%

ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
This is necessary in order to pass in a `SomeTraitVc` to a function which expects `T: ValueDebug`.
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
This is necessary in order to pass in a `SomeTraitVc` to a function which expects `T: ValueDebug`.
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
This is necessary in order to pass in a `SomeTraitVc` to a function which expects `T: ValueDebug`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: automerge Kodiak will merge these automatically after checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants