Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make error overlay message scrollable #3861

Merged
merged 1 commit into from
Feb 17, 2023
Merged

make error overlay message scrollable #3861

merged 1 commit into from
Feb 17, 2023

Conversation

ForsakenHarmony
Copy link
Contributor

@ForsakenHarmony ForsakenHarmony commented Feb 17, 2023 •
edited
Loading

Before long messages would just be hidden:

@ForsakenHarmony ForsakenHarmony requested a review from a team as a code owner February 17, 2023 16:01
@vercel
Copy link

vercel bot commented Feb 17, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
examples-designsystem-docs 🔄 Building (Inspect) Feb 17, 2023 at 4:07PM (UTC)
examples-tailwind-web 🔄 Building (Inspect) Feb 17, 2023 at 4:07PM (UTC)
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 17, 2023 at 4:07PM (UTC)
7 Ignored Deployments
Name Status Preview Comments Updated
examples-basic-web ⬜️ Ignored (Inspect) Feb 17, 2023 at 4:07PM (UTC)
examples-cra-web ⬜️ Ignored (Inspect) Feb 17, 2023 at 4:07PM (UTC)
examples-kitchensink-blog ⬜️ Ignored (Inspect) Feb 17, 2023 at 4:07PM (UTC)
examples-native-web ⬜️ Ignored (Inspect) Feb 17, 2023 at 4:07PM (UTC)
examples-nonmonorepo ⬜️ Ignored (Inspect) Feb 17, 2023 at 4:07PM (UTC)
examples-svelte-web ⬜️ Ignored (Inspect) Feb 17, 2023 at 4:07PM (UTC)
examples-vite-web ⬜️ Ignored (Inspect) Feb 17, 2023 at 4:07PM (UTC)

@ForsakenHarmony
Copy link
Contributor Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@ForsakenHarmony ForsakenHarmony force-pushed the hrmny/web-572-make-error-overlay-message-scrollable branch from 64b70a1 to f275cfd Compare February 17, 2023 16:05
@ForsakenHarmony ForsakenHarmony enabled auto-merge (squash) February 17, 2023 16:22
@github-actions
Copy link
Contributor

github-actions bot commented Feb 17, 2023 •
edited
Loading

🟢 CI successful 🟢

Thanks

@ForsakenHarmony ForsakenHarmony merged commit 7ec99c8 into main Feb 17, 2023
@ForsakenHarmony ForsakenHarmony deleted the hrmny/web-572-make-error-overlay-message-scrollable branch February 17, 2023 16:23
@github-actions
Copy link
Contributor

Benchmark for fc8f14e

Test Base PR % Significant %
bench_hmr_to_commit/Turbopack RSC/1000 modules 510.50ms ± 1.98ms 499.94ms ± 1.41ms -2.07% -0.74%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 9290.08µs ± 74.87µs 9238.40µs ± 96.72µs -0.56%
bench_hmr_to_commit/Turbopack RCC/1000 modules 11.97ms ± 0.26ms 12.38ms ± 0.16ms +3.48%
bench_hmr_to_commit/Turbopack RSC/1000 modules 510.50ms ± 1.98ms 499.94ms ± 1.41ms -2.07% -0.74%
bench_hmr_to_commit/Turbopack SSR/1000 modules 9380.80µs ± 94.56µs 9439.00µs ± 48.26µs +0.62%
bench_hmr_to_eval/Turbopack CSR/1000 modules 8425.97µs ± 91.36µs 8262.53µs ± 78.92µs -1.94%
bench_hmr_to_eval/Turbopack RCC/1000 modules 11.08ms ± 0.37ms 10.76ms ± 0.19ms -2.92%
bench_hmr_to_eval/Turbopack SSR/1000 modules 8432.79µs ± 67.59µs 8418.27µs ± 63.35µs -0.17%
bench_hydration/Turbopack RCC/1000 modules 3699.08ms ± 23.86ms 3654.26ms ± 13.42ms -1.21%
bench_hydration/Turbopack RSC/1000 modules 3324.55ms ± 8.63ms 3347.64ms ± 9.10ms +0.69%
bench_hydration/Turbopack SSR/1000 modules 3405.87ms ± 8.84ms 3394.65ms ± 15.67ms -0.33%
bench_startup/Turbopack CSR/1000 modules 2681.48ms ± 9.37ms 2670.18ms ± 9.03ms -0.42%
bench_startup/Turbopack RCC/1000 modules 2257.76ms ± 2.55ms 2260.80ms ± 3.51ms +0.13%
bench_startup/Turbopack RSC/1000 modules 2188.39ms ± 4.63ms 2190.75ms ± 5.82ms +0.11%
bench_startup/Turbopack SSR/1000 modules 2067.49ms ± 2.79ms 2059.85ms ± 2.40ms -0.37%

sokra added a commit to vercel/next.js that referenced this pull request Feb 21, 2023
@sokra
update turbopack
b623685 
# Performance Improvements

* improve performance of TaskScopes and collectibes ([#3849](https://github.com/vercel/turbo/pull3849/))
* fix consistency issue with reading collectibles ([#3878](vercel/turborepo#3878))
* change to NoHashHasher for ID keys ([#3864](https://github.com/vercel/turbo/pull3864/))

# Bug Fixes

* strip UNC prefix on windows paths ([#3847](https://github.com/vercel/turbo/pull3847/))
* make error overlay message scrollable ([#3861](vercel/turborepo#3861))
* alias @swc/helpers to the version within next.js ([#3865](https://github.com/vercel/turbo/pull3865/))
* add possible unknown mutation to objects and arrays ([#3882](vercel/turborepo#3882))

# Contributing

* Update profiling instructions for macOS ([#3837](https://github.com/vercel/turbo/pull3837/))
@sokra sokra mentioned this pull request Feb 21, 2023
Closed
wbinnssmith added a commit to vercel/next.js that referenced this pull request Feb 21, 2023
@wbinnssmith
Update Turbopack to turbopack-230221.3
c2e7305 
Performance Improvements:
* vercel/turborepo#3849

Misc:
* vercel/turborepo#3850
* vercel/turborepo#3861
* vercel/turborepo#3823
@wbinnssmith wbinnssmith mentioned this pull request Feb 21, 2023
Merged
ijjk pushed a commit to vercel/next.js that referenced this pull request Feb 21, 2023
@wbinnssmith
Update Turbopack to turbopack-230221.3 (#46209
4bfb923 
# Performance Improvements:
* vercel/turborepo#3849
* vercel/turborepo#3878
* vercel/turborepo#3864

# Misc:
* vercel/turborepo#3847
* vercel/turborepo#3865
* vercel/turborepo#3850
* vercel/turborepo#3861
* vercel/turborepo#3823
* vercel/turborepo#3882

# Contributing
* Update profiling instructions for macOS
([#3837](vercel/turborepo#3837))
jridgewell pushed a commit to vercel/next.js that referenced this pull request Mar 10, 2023
@ForsakenHarmony
make error overlay message scrollable (vercel/turborepo#3861)
f1f214f 
Before long messages would just be hidden:

![](https://uploads.linear.app/099ed59a-06c6-472f-9977-4798721bda90/6ea99100-27be-4192-adea-46ff2ed78cc8/860978fd-9ea5-456e-8c5a-48cecacf3e95)
sokra pushed a commit to vercel/next.js that referenced this pull request Mar 13, 2023
@ForsakenHarmony
make error overlay message scrollable (vercel/turborepo#3861)
866dfec 
Before long messages would just be hidden:

![](https://uploads.linear.app/099ed59a-06c6-472f-9977-4798721bda90/6ea99100-27be-4192-adea-46ff2ed78cc8/860978fd-9ea5-456e-8c5a-48cecacf3e95)
@DuCanhGH DuCanhGH mentioned this pull request Mar 15, 2023
Merged
ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Jul 25, 2024
@ForsakenHarmony
make error overlay message scrollable (vercel/turborepo#3861)
89d163f 
Before long messages would just be hidden:

![](https://uploads.linear.app/099ed59a-06c6-472f-9977-4798721bda90/6ea99100-27be-4192-adea-46ff2ed78cc8/860978fd-9ea5-456e-8c5a-48cecacf3e95)
ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@ForsakenHarmony
make error overlay message scrollable (vercel/turborepo#3861)
0c92afc 
Before long messages would just be hidden:

![](https://uploads.linear.app/099ed59a-06c6-472f-9977-4798721bda90/6ea99100-27be-4192-adea-46ff2ed78cc8/860978fd-9ea5-456e-8c5a-48cecacf3e95)
ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Aug 1, 2024
@ForsakenHarmony
make error overlay message scrollable (vercel/turborepo#3861)
ff3b7ec 
Before long messages would just be hidden:

![](https://uploads.linear.app/099ed59a-06c6-472f-9977-4798721bda90/6ea99100-27be-4192-adea-46ff2ed78cc8/860978fd-9ea5-456e-8c5a-48cecacf3e95)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sokra sokra sokra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ForsakenHarmony @sokra