Automatically apply babel-loader for apps with babel configs #3862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will automatically apply `babel-loader` to Next.js apps that include a babel configuration file alongside `next.config.js`. It requires the app to provide `babel-loader` itself. Test Plan: Added an integration test.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Socket Security Pull Request Report👍 No new dependency issues detected in pull request Pull request report summary
Bot CommandsTo ignore an alert, reply with a comment starting with Powered by socket.dev |
ForsakenHarmony
approved these changes
Feb 17, 2023
|
Benchmark for b730c7eClick to view benchmark
|
Benchmark for 4c7aa1d
Click to view full benchmark
|
Benchmark for 2c599adClick to view benchmark
|
sokra
approved these changes
Feb 22, 2023
| let has_babel_config = { | ||
| let mut has_babel_config = false; | ||
| for filename in BABEL_CONFIG_FILES { | ||
| let metadata = project_root.join(filename).metadata().await; |
There was a problem hiding this comment.
Suggested change
| let metadata = project_root.join(filename).metadata().await; | |
| let metadata = project_root.join(filename).get_type().await; |
We usually use get_type for existence checks as it's cheaper as it doesn't require a syscall
There was a problem hiding this comment.
There's also find_context_file which does tree lookups.
| RequestVc::parse(Value::new(Pattern::Constant( | ||
| "babel-loader/package.json".to_string(), | ||
| ))), | ||
| resolve_options( |
There was a problem hiding this comment.
There are node_resolve_options somewhere in our repo. You can use them.
There was a problem hiding this comment.
See assert_can_resolve_react_refresh
jridgewell
reviewed
Feb 22, 2023
| let has_babel_config = { | ||
| let mut has_babel_config = false; | ||
| for filename in BABEL_CONFIG_FILES { | ||
| let metadata = project_root.join(filename).metadata().await; |
There was a problem hiding this comment.
There's also find_context_file which does tree lookups.
|
|
||
| if has_babel_config { | ||
| let mut options = (*webpack_options.await?).clone(); | ||
| for ext in [".js", ".jsx", ".ts", ".tsx", ".cjs", ".mjs"] { |
There was a problem hiding this comment.
Should this be using next_config.page_extensions() instead? Also, what about .cts, .mts, .ctsx, and .mtsx?
| } | ||
| .cell() | ||
| .as_issue() | ||
| .emit() |
There was a problem hiding this comment.
Is this going to be emitted for every extension?
| RequestVc::parse(Value::new(Pattern::Constant( | ||
| "babel-loader/package.json".to_string(), | ||
| ))), | ||
| resolve_options( |
There was a problem hiding this comment.
See assert_can_resolve_react_refresh
Benchmark for 7380915
Click to view full benchmark
|
wbinnssmith
added a commit
that referenced
this pull request
Feb 24, 2023
This: * Addresses feedback from #3862 * Exempts VirtualAssets from webpack loaders. This addresses a bug where next-hydrate.tsx could not be read. * Adds `ModuleRuleCondition::ResourceIsVirtualAsset` to filter these
wbinnssmith
added a commit
that referenced
this pull request
Feb 27, 2023
This: * Addresses feedback from #3862 * Exempts VirtualAssets from webpack loaders. This addresses a bug where next-hydrate.tsx could not be read. * Adds `ModuleRuleCondition::ResourceIsVirtualAsset` to filter these --------- Co-authored-by: Justin Ridgewell <justin@ridgewell.name>
jridgewell
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 10, 2023
…turborepo#3862) This will automatically apply `babel-loader` to Next.js apps that include a babel configuration file alongside `next.config.js`. It requires the app to provide `babel-loader` itself. Test Plan: Added an integration test.
jridgewell
added a commit
to vercel/next.js
that referenced
this pull request
Mar 10, 2023
This: * Addresses feedback from vercel/turborepo#3862 * Exempts VirtualAssets from webpack loaders. This addresses a bug where next-hydrate.tsx could not be read. * Adds `ModuleRuleCondition::ResourceIsVirtualAsset` to filter these --------- Co-authored-by: Justin Ridgewell <justin@ridgewell.name>
sokra
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 13, 2023
…turborepo#3862) This will automatically apply `babel-loader` to Next.js apps that include a babel configuration file alongside `next.config.js`. It requires the app to provide `babel-loader` itself. Test Plan: Added an integration test.
sokra
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 13, 2023
This: * Addresses feedback from vercel/turborepo#3862 * Exempts VirtualAssets from webpack loaders. This addresses a bug where next-hydrate.tsx could not be read. * Adds `ModuleRuleCondition::ResourceIsVirtualAsset` to filter these --------- Co-authored-by: Justin Ridgewell <justin@ridgewell.name>
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
…turborepo#3862) This will automatically apply `babel-loader` to Next.js apps that include a babel configuration file alongside `next.config.js`. It requires the app to provide `babel-loader` itself. Test Plan: Added an integration test.
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
This: * Addresses feedback from vercel/turborepo#3862 * Exempts VirtualAssets from webpack loaders. This addresses a bug where next-hydrate.tsx could not be read. * Adds `ModuleRuleCondition::ResourceIsVirtualAsset` to filter these --------- Co-authored-by: Justin Ridgewell <justin@ridgewell.name>
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
…turborepo#3862) This will automatically apply `babel-loader` to Next.js apps that include a babel configuration file alongside `next.config.js`. It requires the app to provide `babel-loader` itself. Test Plan: Added an integration test.
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
This: * Addresses feedback from vercel/turborepo#3862 * Exempts VirtualAssets from webpack loaders. This addresses a bug where next-hydrate.tsx could not be read. * Adds `ModuleRuleCondition::ResourceIsVirtualAsset` to filter these --------- Co-authored-by: Justin Ridgewell <justin@ridgewell.name>
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
…turborepo#3862) This will automatically apply `babel-loader` to Next.js apps that include a babel configuration file alongside `next.config.js`. It requires the app to provide `babel-loader` itself. Test Plan: Added an integration test.
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
This: * Addresses feedback from vercel/turborepo#3862 * Exempts VirtualAssets from webpack loaders. This addresses a bug where next-hydrate.tsx could not be read. * Adds `ModuleRuleCondition::ResourceIsVirtualAsset` to filter these --------- Co-authored-by: Justin Ridgewell <justin@ridgewell.name>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will automatically apply
babel-loaderto Next.js apps that include a babel configuration file alongsidenext.config.js. It requires the app to providebabel-loaderitself.Test Plan: Added an integration test.