Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include chunk path in WithClientChunks #3910

Merged
merged 2 commits into from
Feb 22, 2023
Merged

Include chunk path in WithClientChunks #3910

merged 2 commits into from
Feb 22, 2023

Conversation

alexkirsz
Copy link
Contributor

WithClientChunksChunkItem currently only includes paths to chunks' references, but not chunks themselves.

Fixes WEB-621.

@alexkirsz alexkirsz requested a review from a team as a code owner February 22, 2023 11:01
@vercel
Copy link

vercel bot commented Feb 22, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 22, 2023 at 0:15AM (UTC)
9 Ignored Deployments
Name Status Preview Comments Updated
examples-basic-web ⬜️ Ignored (Inspect) Feb 22, 2023 at 0:15AM (UTC)
examples-cra-web ⬜️ Ignored (Inspect) Feb 22, 2023 at 0:15AM (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Feb 22, 2023 at 0:15AM (UTC)
examples-kitchensink-blog ⬜️ Ignored (Inspect) Feb 22, 2023 at 0:15AM (UTC)
examples-native-web ⬜️ Ignored (Inspect) Feb 22, 2023 at 0:15AM (UTC)
examples-nonmonorepo ⬜️ Ignored (Inspect) Feb 22, 2023 at 0:15AM (UTC)
examples-svelte-web ⬜️ Ignored (Inspect) Feb 22, 2023 at 0:15AM (UTC)
examples-tailwind-web ⬜️ Ignored (Inspect) Feb 22, 2023 at 0:15AM (UTC)
examples-vite-web ⬜️ Ignored (Inspect) Feb 22, 2023 at 0:15AM (UTC)

@github-actions
Copy link
Contributor

github-actions bot commented Feb 22, 2023 •
edited
Loading

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@sokra
Copy link
Member

sokra commented Feb 22, 2023 •
edited
Loading

clippy

@sokra sokra closed this Feb 22, 2023
@sokra sokra reopened this Feb 22, 2023
@alexkirsz alexkirsz added the pr: automerge Kodiak will merge these automatically after checks pass label Feb 22, 2023
@kodiakhq kodiakhq bot merged commit 8c993e5 into main Feb 22, 2023
@kodiakhq kodiakhq bot deleted the alexkirsz/web-621-app-playground-css branch February 22, 2023 12:39
@github-actions
Copy link
Contributor

Benchmark for 39575a6

Test Base PR % Significant %
bench_startup/Turbopack SSR/1000 modules 2087.14ms ± 2.51ms 2098.75ms ± 2.58ms +0.56% +0.07%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 9702.76µs ± 70.75µs 9699.93µs ± 76.70µs -0.03%
bench_hmr_to_commit/Turbopack RCC/1000 modules 12.16ms ± 0.31ms 12.55ms ± 0.14ms +3.22%
bench_hmr_to_commit/Turbopack RSC/1000 modules 510.82ms ± 2.07ms 511.61ms ± 1.51ms +0.15%
bench_hmr_to_commit/Turbopack SSR/1000 modules 9832.56µs ± 62.42µs 9912.71µs ± 63.13µs +0.82%
bench_hmr_to_eval/Turbopack CSR/1000 modules 7932.29µs ± 96.85µs 7969.49µs ± 32.06µs +0.47%
bench_hmr_to_eval/Turbopack RCC/1000 modules 10.85ms ± 0.19ms 10.91ms ± 0.28ms +0.53%
bench_hmr_to_eval/Turbopack SSR/1000 modules 8068.90µs ± 65.59µs 8043.10µs ± 88.01µs -0.32%
bench_hydration/Turbopack RCC/1000 modules 3775.84ms ± 21.92ms 3739.94ms ± 21.65ms -0.95%
bench_hydration/Turbopack RSC/1000 modules 3384.08ms ± 7.71ms 3370.72ms ± 11.45ms -0.39%
bench_hydration/Turbopack SSR/1000 modules 3457.54ms ± 17.00ms 3434.41ms ± 11.71ms -0.67%
bench_startup/Turbopack CSR/1000 modules 2745.44ms ± 9.94ms 2720.18ms ± 17.28ms -0.92%
bench_startup/Turbopack RCC/1000 modules 2312.35ms ± 4.41ms 2296.95ms ± 5.70ms -0.67%
bench_startup/Turbopack RSC/1000 modules 2220.23ms ± 4.71ms 2221.45ms ± 4.82ms +0.05%
bench_startup/Turbopack SSR/1000 modules 2087.14ms ± 2.51ms 2098.75ms ± 2.58ms +0.56% +0.07%

@sokra sokra mentioned this pull request Feb 22, 2023
Merged
ijjk pushed a commit to vercel/next.js that referenced this pull request Feb 22, 2023
@sokra
update turbopack (#46253
3d73366 
# Features

* vercel/turborepo#3897
* vercel/turborepo#3670

# Bug Fixes

* vercel/turborepo#3894
* vercel/turborepo#3910
* vercel/turborepo#3895
* vercel/turborepo#3912
* vercel/turborepo#3805

# Performance Improvements

* vercel/turborepo#3836
jridgewell pushed a commit to vercel/next.js that referenced this pull request Mar 10, 2023
@alexkirsz
Include chunk path in WithClientChunks (vercel/turborepo#3910)
79eac2b 
`WithClientChunksChunkItem` currently only includes paths to chunks' references, but not chunks themselves.

Fixes WEB-621.
sokra pushed a commit to vercel/next.js that referenced this pull request Mar 13, 2023
@alexkirsz
Include chunk path in WithClientChunks (vercel/turborepo#3910)
36aca51 
`WithClientChunksChunkItem` currently only includes paths to chunks' references, but not chunks themselves.

Fixes WEB-621.
@DuCanhGH DuCanhGH mentioned this pull request Mar 15, 2023
Merged
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
@alexkirsz
Include chunk path in WithClientChunks (vercel/turborepo#3910)
a2de0d2 
`WithClientChunksChunkItem` currently only includes paths to chunks' references, but not chunks themselves.

Fixes WEB-621.
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@alexkirsz
Include chunk path in WithClientChunks (vercel/turborepo#3910)
9cf4023 
`WithClientChunksChunkItem` currently only includes paths to chunks' references, but not chunks themselves.

Fixes WEB-621.
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
@alexkirsz
Include chunk path in WithClientChunks (vercel/turborepo#3910)
a834c20 
`WithClientChunksChunkItem` currently only includes paths to chunks' references, but not chunks themselves.

Fixes WEB-621.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sokra sokra sokra approved these changes

Assignees
No one assigned
Labels
pr: automerge Kodiak will merge these automatically after checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexkirsz @sokra