-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Custom Transformers #4202
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
|
sokra
force-pushed
the
jrl-custom-transformers
branch
from
March 15, 2023 07:40
d7f114f
to
0e2b389
Compare
sokra
approved these changes
Mar 15, 2023
sokra
added
the
pr: automerge
Kodiak will merge these automatically after checks pass
label
Mar 15, 2023
kodiakhq bot
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 15, 2023
Builds on vercel/turborepo#4202 to implement custom Next.js Transformers in Turbopack. This is the final piece to moving the `next-*` crates to Next. While we've _technically_ moved everything, Turbopack didn't support running custom transformers. So we're actually stuck on the last version we cut before deleting the next crates, running the transformers that exist in the turbopack repo. With the new support, we're almost back to the tip of main branch (there's still some snafu with `swc_core` upgrading that I'm working on). Co-authored-by: Tobias Koppers <1365881+sokra@users.noreply.github.com>
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
The final part of moving the `next-*` crates to Next.js is to allow them to use their own custom JS Transformers. This was a bit of a headache. Our `turbo/nextpack` setup just doesn't work with coc.nvim, we're midway through an SWC upgrade across our repos, and I somehow `git reset --hard` the &*#(@$ changes while working. --------- Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
The final part of moving the `next-*` crates to Next.js is to allow them to use their own custom JS Transformers. This was a bit of a headache. Our `turbo/nextpack` setup just doesn't work with coc.nvim, we're midway through an SWC upgrade across our repos, and I somehow `git reset --hard` the &*#(@$ changes while working. --------- Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
The final part of moving the `next-*` crates to Next.js is to allow them to use their own custom JS Transformers. This was a bit of a headache. Our `turbo/nextpack` setup just doesn't work with coc.nvim, we're midway through an SWC upgrade across our repos, and I somehow `git reset --hard` the &*#(@$ changes while working. --------- Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The final part of moving the
next-*
crates to Next.js is to allow them to use their own custom JS Transformers.This was a bit of a headache. Our
turbo/nextpack
setup just doesn't work with coc.nvim, we're midway through an SWC upgrade across our repos, and I somehowgit reset --hard
the &*#(@$ changes while working.