Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Custom Transformers #4202

Merged
merged 5 commits into from
Mar 15, 2023
Merged

Implement Custom Transformers #4202

merged 5 commits into from
Mar 15, 2023

Conversation

jridgewell
Copy link
Contributor

The final part of moving the next-* crates to Next.js is to allow them to use their own custom JS Transformers.

This was a bit of a headache. Our turbo/nextpack setup just doesn't work with coc.nvim, we're midway through an SWC upgrade across our repos, and I somehow git reset --hard the &*#(@$ changes while working.

@jridgewell jridgewell requested a review from a team as a code owner March 15, 2023 03:33
@vercel
Copy link

vercel bot commented Mar 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
examples-native-web 🔄 Building (Inspect) Mar 15, 2023 at 9:19AM (UTC)
turbo-site 🔄 Building (Inspect) Visit Preview Mar 15, 2023 at 9:19AM (UTC)
8 Ignored Deployments
Name Status Preview Comments Updated
examples-basic-web ⬜️ Ignored (Inspect) Mar 15, 2023 at 9:19AM (UTC)
examples-cra-web ⬜️ Ignored (Inspect) Mar 15, 2023 at 9:19AM (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Mar 15, 2023 at 9:19AM (UTC)
examples-kitchensink-blog ⬜️ Ignored (Inspect) Mar 15, 2023 at 9:19AM (UTC)
examples-nonmonorepo ⬜️ Ignored (Inspect) Mar 15, 2023 at 9:19AM (UTC)
examples-svelte-web ⬜️ Ignored (Inspect) Mar 15, 2023 at 9:19AM (UTC)
examples-tailwind-web ⬜️ Ignored (Inspect) Mar 15, 2023 at 9:19AM (UTC)
examples-vite-web ⬜️ Ignored (Inspect) Mar 15, 2023 at 9:19AM (UTC)

@github-actions
Copy link
Contributor

github-actions bot commented Mar 15, 2023

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@sokra sokra requested a review from a team as a code owner March 15, 2023 09:18
@sokra sokra requested review from nathanhammond and arlyon March 15, 2023 09:18
@sokra sokra added the pr: automerge Kodiak will merge these automatically after checks pass label Mar 15, 2023
@kodiakhq kodiakhq bot merged commit faaf54e into main Mar 15, 2023
@kodiakhq kodiakhq bot deleted the jrl-custom-transformers branch March 15, 2023 09:46
kodiakhq bot pushed a commit to vercel/next.js that referenced this pull request Mar 15, 2023
Builds on vercel/turborepo#4202 to implement custom Next.js Transformers in Turbopack.

This is the final piece to moving the `next-*` crates to Next. While we've _technically_ moved everything, Turbopack didn't support running custom transformers. So we're actually stuck on the last version we cut before deleting the next crates, running the transformers that exist in the turbopack repo. With the new support, we're almost back to the tip of main branch (there's still some snafu with `swc_core` upgrading that I'm working on).

Co-authored-by: Tobias Koppers <1365881+sokra@users.noreply.github.com>
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
The final part of moving the `next-*` crates to Next.js is to allow them
to use their own custom JS Transformers.

This was a bit of a headache. Our `turbo/nextpack` setup just doesn't
work with coc.nvim, we're midway through an SWC upgrade across our
repos, and I somehow `git reset --hard` the &*#(@$ changes while
working.

---------

Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
The final part of moving the `next-*` crates to Next.js is to allow them
to use their own custom JS Transformers.

This was a bit of a headache. Our `turbo/nextpack` setup just doesn't
work with coc.nvim, we're midway through an SWC upgrade across our
repos, and I somehow `git reset --hard` the &*#(@$ changes while
working.

---------

Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
The final part of moving the `next-*` crates to Next.js is to allow them
to use their own custom JS Transformers.

This was a bit of a headache. Our `turbo/nextpack` setup just doesn't
work with coc.nvim, we're midway through an SWC upgrade across our
repos, and I somehow `git reset --hard` the &*#(@$ changes while
working.

---------

Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: automerge Kodiak will merge these automatically after checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants