Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synthesize a command for a Run #4499

Merged
merged 3 commits into from
Apr 10, 2023
Merged

Conversation

gsoltis
Copy link
Contributor

@gsoltis gsoltis commented Apr 7, 2023

  • Switches pkgInferencePath to be a RelativeSystemPath (note "" token for not set)
  • Records repositoryPath in Run Payload
  • Switches timestamps over to int64 since they milliseconds
  • Synthesizes a plausible command to produce an identical set of tasks and packages to execute

Note merge base is #4495

Testing Instructions

Added a new test for command syntheses

@gsoltis gsoltis requested a review from a team as a code owner April 7, 2023 19:14
@vercel
Copy link

vercel bot commented Apr 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web 🔄 Building (Inspect) Apr 10, 2023 5:09pm
examples-designsystem-docs 🔄 Building (Inspect) Apr 10, 2023 5:09pm
examples-kitchensink-blog 🔄 Building (Inspect) Apr 10, 2023 5:09pm
examples-vite-web 🔄 Building (Inspect) Apr 10, 2023 5:09pm
turbo-site 🔄 Building (Inspect) Visit Preview Apr 10, 2023 5:09pm
6 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-cra-web ⬜️ Ignored (Inspect) Apr 10, 2023 5:09pm
examples-gatsby-web ⬜️ Ignored (Inspect) Apr 10, 2023 5:09pm
examples-native-web ⬜️ Ignored (Inspect) Apr 10, 2023 5:09pm
examples-nonmonorepo ⬜️ Ignored (Inspect) Apr 10, 2023 5:09pm
examples-svelte-web ⬜️ Ignored (Inspect) Apr 10, 2023 5:09pm
examples-tailwind-web ⬜️ Ignored (Inspect) Apr 10, 2023 5:09pm

@gsoltis gsoltis changed the title Update data sent to vercel for runs Synthesize a command for a Run Apr 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2023

🟢 CI successful 🟢

Thanks

func newVercelRunCreatePayload(runsummary *RunSummary) *vercelRunPayload {
startTime := int(runsummary.ExecutionSummary.startedAt.UnixMilli())
var context = "LOCAL"
func (rsm *Meta) newVercelRunCreatePayload() *vercelRunPayload {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's going into the spaces payload, it should be part of the Run Summary. It seems like good information regardless. If you're good with that, we can merge this in and I'll update in my PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added to execution summary

@gsoltis gsoltis merged commit 99a8b68 into mk/vercel-data-massage Apr 10, 2023
@gsoltis gsoltis deleted the gsoltis/command_and_dir branch April 10, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants