pass original url with content source data #4818
Merged
+24
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
10 Ignored Deployments
|
|
✅ This change can build |
🟢 CI successful 🟢Thanks |
alexkirsz
approved these changes
May 4, 2023
alexkirsz
reviewed
May 4, 2023
| @@ -236,6 +236,9 @@ pub struct ContentSourceData { | |||
| pub method: Option<String>, | |||
| /// The full url (including query string), if requested. | |||
| pub url: Option<String>, | |||
| /// The full url (including query string) before rewrites where applied, if | |||
| /// requested. | |||
There was a problem hiding this comment.
Would be nice to explain why this might be useful to a consumer.
sokra
added a commit
to vercel/next.js
that referenced
this pull request
May 4, 2023
### What? Use pre-rewrite URL for rendering ### Why? Rendering app pages needs the original user facing URL. ### Turbopack changes * vercel/turborepo#4818 <!-- Tobias Koppers - pass original url with content source data --> * vercel/turborepo#4817 <!-- Tobias Koppers - avoid errors in computing issue details -->
gsoltis
pushed a commit
that referenced
this pull request
May 5, 2023
### Description next.js needs the pre-rewrite url for rendering see vercel/next.js#49198
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
### Description next.js needs the pre-rewrite url for rendering see #49198
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description next.js needs the pre-rewrite url for rendering see #49198
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
### Description next.js needs the pre-rewrite url for rendering see #49198
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
next.js needs the pre-rewrite url for rendering
see vercel/next.js#49198