Re-throw module.error when instantiating runtime modules #4918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
10 Ignored Deployments
|
|
✅ This change can build |
alexkirsz
commented
May 12, 2023
| } catch (error) { | ||
| module.error = error; | ||
| throw error; | ||
| } |
There was a problem hiding this comment.
This change is purely aesthetic.
| throw e; | ||
| } finally { | ||
| // Always cleanup the intercept, even if module execution failed. | ||
| cleanupReactRefreshIntercept(); |
There was a problem hiding this comment.
This change isn't related to the issue, but since we don't expect the runtime to completely crash and burn after a module instantiation error occurs, we should still clean up any side-effects.
| @@ -1418,6 +1424,9 @@ function instantiateRuntimeModule(moduleId, chunkPath) { | |||
| function getOrInstantiateRuntimeModule(moduleId, chunkPath) { | |||
| const module = moduleCache[moduleId]; | |||
| if (module) { | |||
| if (module.error) { | |||
| throw module.error; | |||
| } | |||
There was a problem hiding this comment.
This is the actual fix.
🟢 CI successful 🟢Thanks |
ForsakenHarmony
approved these changes
May 12, 2023
alexkirsz
added
the
pr: automerge
kodiakhq
bot
deleted the
alexkirsz/web-1045-dashboard-cannot-read-properties-of
branch
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
…orepo#4918) ### Description Runtime modules can be executed multiple times within the same context. However, when such a module encounters a runtime error during execution, this error is cached in module.error and not properly re-thrown when the module is required again from `getOrInstantiateRuntimeModule`, which means that on later runs we’ll silently fail to instantiate the module, and run into any errors that expects a global side-effect from the module. link WEB-1045
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
…orepo#4918) ### Description Runtime modules can be executed multiple times within the same context. However, when such a module encounters a runtime error during execution, this error is cached in module.error and not properly re-thrown when the module is required again from `getOrInstantiateRuntimeModule`, which means that on later runs we’ll silently fail to instantiate the module, and run into any errors that expects a global side-effect from the module. link WEB-1045
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
…orepo#4918) ### Description Runtime modules can be executed multiple times within the same context. However, when such a module encounters a runtime error during execution, this error is cached in module.error and not properly re-thrown when the module is required again from `getOrInstantiateRuntimeModule`, which means that on later runs we’ll silently fail to instantiate the module, and run into any errors that expects a global side-effect from the module. link WEB-1045
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Runtime modules can be executed multiple times within the same context. However, when such a module encounters a runtime error during execution, this error is cached in module.error and not properly re-thrown when the module is required again from
getOrInstantiateRuntimeModule, which means that on later runs we’ll silently fail to instantiate the module, and run into any errors that expects a global side-effect from the module.link WEB-1045