feat(turbopack_core): define trait for diagnostics #5503
Merged
+85
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
10 Ignored Deployments
|
|
✅ This change can build |
|
Linux Benchmark for 41d5034Click to view benchmark
|
MacOS Benchmark for 41d5034
Click to view full benchmark
|
Linux Benchmark for 3bd8e5dClick to view benchmark
|
MacOS Benchmark for 3bd8e5d
Click to view full benchmark
|
jridgewell
reviewed
Jul 17, 2023
kwonoj
force-pushed
the
feat-diag-type
branch
2 times, most recently
from
4ab2ad7
to
4f0984f
Compare
Linux Benchmark for 5b0bf11Click to view benchmark
|
MacOS Benchmark for 5b0bf11
Click to view full benchmark
|
Windows Benchmark for 5b0bf11
Click to view full benchmark
|
Linux Benchmark for ecf2e2dClick to view benchmark
|
Linux Benchmark for 59140b8Click to view benchmark
|
MacOS Benchmark for 59140b8
Click to view full benchmark
|
Linux Benchmark for 1f66ed7Click to view benchmark
|
MacOS Benchmark for 1f66ed7
Click to view full benchmark
|
Linux Benchmark for f98426cClick to view benchmark
|
MacOS Benchmark for f98426c
Click to view full benchmark
|
jridgewell
approved these changes
Jul 20, 2023
Linux Benchmark for b928e8f
Click to view full benchmark
|
MacOS Benchmark for b928e8f
Click to view full benchmark
|
kwonoj
added
the
pr: automerge
sokra
added a commit
to vercel/next.js
that referenced
this pull request
Jul 21, 2023
* vercel/turborepo#5567 <!-- Alex Kirszenberg - Remove unnecessary ValueDebugFormat item, hide Vc field --> * vercel/turborepo#5576 <!-- Alex Kirszenberg - Extract shared HMR utils to their own modules/crates --> * vercel/turborepo#5503 <!-- OJ Kwon - feat(turbopack_core): define trait for diagnostics --> * vercel/turborepo#5487 <!-- Will Binns-Smith - turbopack-cli: modularize code to support turbopack build --> * vercel/turborepo#5488 <!-- Will Binns-Smith - turbopack-cli: implement `turbopack build` --> * vercel/turborepo#5450 <!-- Leah - feat: async modules / top level await --> --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extracting trait definition from vercel/next.js#52356, renamed it for more generic usage that turbopack can emit any kind of arbitary metadata, but next-swc can use it as telemetry for its subset.