Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Added clippy deny all to crates #5514

Merged
merged 1 commit into from
Jul 13, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions crates/turborepo-api-client/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
#![feature(async_closure)]
#![feature(provide_any)]
#![feature(error_generic_member_access)]
#![deny(clippy::all)]

use std::env;

Expand Down
4 changes: 2 additions & 2 deletions crates/turborepo-cache/src/http.rs
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ impl HttpCache {

let body = response.bytes().await.map_err(|e| {
CacheError::ApiClientError(
turborepo_api_client::Error::ReqwestError(e),
Box::new(turborepo_api_client::Error::ReqwestError(e)),
Backtrace::capture(),
)
})?;
Expand All @@ -143,7 +143,7 @@ impl HttpCache {
} else {
response.bytes().await.map_err(|e| {
CacheError::ApiClientError(
turborepo_api_client::Error::ReqwestError(e),
Box::new(turborepo_api_client::Error::ReqwestError(e)),
Backtrace::capture(),
)
})?
Expand Down
9 changes: 8 additions & 1 deletion crates/turborepo-cache/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
#![feature(error_generic_member_access)]
#![feature(provide_any)]
#![deny(clippy::all)]

pub mod cache_archive;
pub mod http;
Expand All @@ -25,7 +26,7 @@ pub enum CacheError {
#[error("cannot untar file to {0}")]
InvalidFilePath(String, #[backtrace] Backtrace),
#[error("artifact verification failed: {0}")]
ApiClientError(#[from] turborepo_api_client::Error, #[backtrace] Backtrace),
ApiClientError(Box<turborepo_api_client::Error>, #[backtrace] Backtrace),
#[error("signing artifact failed: {0}")]
SignatureError(#[from] SignatureError, #[backtrace] Backtrace),
#[error("invalid duration")]
Expand All @@ -52,6 +53,12 @@ pub enum CacheError {
LinkOutsideOfDirectory(String, #[backtrace] Backtrace),
}

impl From<turborepo_api_client::Error> for CacheError {
fn from(value: turborepo_api_client::Error) -> Self {
CacheError::ApiClientError(Box::new(value), Backtrace::capture())
}
}

#[derive(Debug, Clone, PartialEq)]
pub enum CacheSource {
Local,
Expand Down
2 changes: 2 additions & 0 deletions crates/turborepo-env/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
#![deny(clippy::all)]

use std::{
collections::HashMap,
env,
Expand Down
2 changes: 2 additions & 0 deletions crates/turborepo-fs/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
#![deny(clippy::all)]

use std::fs::{self, DirBuilder, Metadata};

use anyhow::Result;
Expand Down Expand Up @@ -64,7 +66,7 @@

fn make_dir_copy(
dir: impl AsRef<AbsoluteSystemPath>,
#[allow(dead_code)] src_metadata: &Metadata,

Check warning on line 69 in crates/turborepo-fs/src/lib.rs

View workflow job for this annotation

GitHub Actions / Go Unit Tests (windows, windows-latest)

unused variable: `src_metadata`
) -> Result<()> {
let dir = dir.as_ref();
let mut builder = DirBuilder::new();
Expand Down
1 change: 1 addition & 0 deletions crates/turborepo-globwalk/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
#![feature(assert_matches)]
#![deny(clippy::all)]

mod empty_glob;

Expand Down
1 change: 1 addition & 0 deletions crates/turborepo-lib/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
#![feature(box_patterns)]
#![feature(error_generic_member_access)]
#![feature(provide_any)]
#![deny(clippy::all)]

mod child;
mod cli;
Expand Down
2 changes: 2 additions & 0 deletions crates/turborepo-lockfiles/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
#![deny(clippy::all)]

mod berry;
mod error;
mod npm;
Expand Down
1 change: 1 addition & 0 deletions crates/turborepo-paths/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
#![feature(assert_matches)]
#![feature(fs_try_exists)]
#![deny(clippy::all)]

/// Turborepo's path handling library
/// Defines distinct path types for the different usecases of paths in turborepo
Expand Down
2 changes: 2 additions & 0 deletions crates/turborepo-pidlock/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
#![deny(clippy::all)]

use std::{
convert::TryInto,
fs,
Expand Down
1 change: 1 addition & 0 deletions crates/turborepo-scm/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
#![feature(error_generic_member_access)]
#![feature(provide_any)]
#![feature(assert_matches)]
#![deny(clippy::all)]

use std::{
backtrace::{self, Backtrace},
Expand Down
2 changes: 2 additions & 0 deletions crates/turborepo-updater/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
#![deny(clippy::all)]

use std::{fmt, time::Duration};

use console::style;
Expand Down
2 changes: 2 additions & 0 deletions crates/turborepo-vercel-api-mock/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
#![deny(clippy::all)]

use std::{collections::HashMap, fs::OpenOptions, io::Write, net::SocketAddr, sync::Arc};

use anyhow::Result;
Expand Down
2 changes: 2 additions & 0 deletions crates/turborepo/src/main.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
#![deny(clippy::all)]

use std::{
env::{consts, current_exe},
process,
Expand Down
Loading