-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add examples/with-docker-pnpm
sample of using pnpm and docker
#5536
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
7 Ignored Deployments
|
@nicu-chiciuc is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
I'm building this way too, and it's a bit frustrating. |
@nicu-chiciuc there's a good chance you'll need to add some configuration to get what you need. I added an example in this comment but your scenario might be slightly different, I don't know yet, feel free to open an issue where I can try and help work it out with you. |
I will close this branch for now. I think it may serve as a good starter example for someone, even if it's not merged in the official package. |
Description
Based on:
This PR adds a new example of using docker pnpm.
I've tried to keep the project code and structure similar to the existing
examples/with-docker
project with some updated goals:api
app is strongly typed, but uses standard ESM instead of relying on a build step. Additional type information can be added using JsDoc.I've also installed
syncpack
to check if there are any mismatches. I've added a package.json script for it, and it can be ran like this:Unfortunately it also show errors for the local dependencies: JamieMason/syncpack#121
but it will also show other mismatches, so I could pretty easily fix those.
Testing Instructions
I've personally tested this by
./examples/with-docker-pnpm
pnpm install
)The previous step may not work by default (it didn't for me) because the root package.json has this:
And my local pnpm was
8.6.5
.While writing this PR I just removed that requirement for pnpm.
This doesn't seem like a nice solution.
A simpler solution would be to copy the
with-docker-pnpm
folder into a different folder and follow the instruction in the README. This seems like a better solution since this is how a potential user would use the example.After copying the folder, run:
and/or
both methods should work.