prefer Option<Vc<IssueSource>> over Vc<OptionIssueSource> #6229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 11 Ignored Deployments
|
|
✅ This change can build |
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
wbinnssmith
approved these changes
Oct 20, 2023
kodiakhq bot
pushed a commit
to vercel/next.js
that referenced
this pull request
Oct 20, 2023
### What? see vercel/turborepo#6229 ### Why? ### How? Closes WEB-1808
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
…borepo#6229) ### Description Avoid passing a nested Vc when an Option Vc is enough ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> Closes WEB-1807
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
…borepo#6229) ### Description Avoid passing a nested Vc when an Option Vc is enough ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> Closes WEB-1807
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
…borepo#6229) ### Description Avoid passing a nested Vc when an Option Vc is enough ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> Closes WEB-1807
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Avoid passing a nested Vc when an Option Vc is enough
Testing Instructions
Closes WEB-1807