feat(turbopack-ecmascript): use import attributes for annotations #6732

ForsakenHarmony · 2023-12-07T14:30:39Z

Description

No more magic string literal 🎉

This also enables with { type: "json }

vercel · 2023-12-07T14:30:51Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
examples-nonmonorepo	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 15, 2024 10:23pm
examples-tailwind-web	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	May 15, 2024 10:23pm
examples-vite-web	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	May 15, 2024 10:23pm
rust-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 15, 2024 10:23pm

7 Ignored Deployments

Name	Status	Preview	Updated (UTC)
examples-basic-web	⬜️ Ignored (Inspect)	Visit Preview	May 15, 2024 10:23pm
examples-designsystem-docs	⬜️ Ignored (Inspect)	Visit Preview	May 15, 2024 10:23pm
examples-gatsby-web	⬜️ Ignored (Inspect)	Visit Preview	May 15, 2024 10:23pm
examples-kitchensink-blog	⬜️ Ignored (Inspect)	Visit Preview	May 15, 2024 10:23pm
examples-native-web	⬜️ Ignored (Inspect)	Visit Preview	May 15, 2024 10:23pm
examples-svelte-web	⬜️ Ignored (Inspect)	Visit Preview	May 15, 2024 10:23pm
turbo-site	⬜️ Ignored (Inspect)		May 15, 2024 10:23pm

github-actions · 2023-12-07T14:33:39Z

🟢 Turbopack Benchmark CI successful 🟢

Thanks

github-actions · 2023-12-07T14:36:03Z

✅ This change can build next-swc

github-actions · 2023-12-07T14:40:20Z

⚠️ CI failed ⚠️

The following steps have failed in CI:

Turbopack Rust tests (linux)
Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

github-actions · 2023-12-07T14:47:56Z

Linux Benchmark for `22d3e14`

Click to view benchmark

Test	Base	PR	%
bench_hmr_to_commit/Turbopack CSR/1000 modules	24.18ms ± 0.74ms	24.23ms ± 0.75ms	+0.21%
bench_hmr_to_eval/Turbopack CSR/1000 modules	23.65ms ± 0.69ms	23.68ms ± 0.72ms	+0.15%
bench_startup/Turbopack CSR/1000 modules	1363.28ms ± 3.79ms	1363.75ms ± 4.91ms	+0.03%

ForsakenHarmony · 2024-05-15T14:50:42Z

crates/turbopack-resolve/src/ecmascript.rs

+        reference_type.into_value(),
+        ReferenceType::EcmaScriptModules(EcmaScriptModulesReferenceSubType::ImportWithType(_))
+    ) {
+        options.extensions.clear();


Is this correct for with { type: "json" }?

ForsakenHarmony · 2024-05-15T14:50:47Z

crates/turbopack/src/lib.rs

    for (i, rule) in options.await?.rules.iter().enumerate() {
+        if has_type_attribute && current_module_type.is_some() {


Is this correct for with { type: "json" }?

ForsakenHarmony · 2024-05-16T00:10:05Z

If the with { type: "json" } support needs changes, it can be done in a follow-up PR

…rcel#6732)

…rcel/turborepo#6732)

turbo-orchestrator bot added created-by: turbopack labels Dec 7, 2023

vercel bot had a problem deploying to Preview – rust-docs December 7, 2023 14:31 Failure

ForsakenHarmony mentioned this pull request Dec 7, 2023

feat(turbopack-ecmascript): use import attributes for annotations vercel/next.js#59370

Merged

sokra approved these changes Feb 29, 2024

View reviewed changes

ForsakenHarmony force-pushed the hrmny/import-attribute-annotations branch from 243047d to da02f16 Compare April 24, 2024 21:15

vercel bot deployed to Preview – examples-nonmonorepo April 24, 2024 21:16 View deployment

vercel bot deployed to Preview – rust-docs April 24, 2024 21:26 View deployment

ForsakenHarmony force-pushed the hrmny/import-attribute-annotations branch from da02f16 to bcb047d Compare April 25, 2024 14:22

vercel bot deployed to Preview – examples-nonmonorepo April 25, 2024 14:22 View deployment

vercel bot deployed to Preview – rust-docs April 25, 2024 14:32 View deployment

ForsakenHarmony force-pushed the hrmny/import-attribute-annotations branch from bcb047d to 968934c Compare April 25, 2024 15:53

vercel bot deployed to Preview – examples-nonmonorepo April 25, 2024 15:53 View deployment

vercel bot deployed to Preview – rust-docs April 25, 2024 16:03 View deployment

ForsakenHarmony force-pushed the hrmny/import-attribute-annotations branch from 968934c to 61f64d2 Compare April 26, 2024 17:01

vercel bot deployed to Preview – examples-nonmonorepo April 26, 2024 17:02 View deployment

vercel bot deployed to Preview – rust-docs April 26, 2024 17:12 View deployment

ForsakenHarmony force-pushed the hrmny/import-attribute-annotations branch from 61f64d2 to 98c813c Compare April 26, 2024 17:30

vercel bot deployed to Preview – examples-nonmonorepo April 26, 2024 17:30 View deployment

vercel bot deployed to Preview – rust-docs April 26, 2024 17:40 View deployment

ForsakenHarmony force-pushed the hrmny/import-attribute-annotations branch from 98c813c to edc69b8 Compare May 8, 2024 22:05

vercel bot deployed to Preview – examples-nonmonorepo May 8, 2024 22:05 View deployment

vercel bot deployed to Preview – rust-docs May 8, 2024 22:15 View deployment

ForsakenHarmony force-pushed the hrmny/import-attribute-annotations branch from edc69b8 to 96a1fee Compare May 13, 2024 20:34

vercel bot deployed to Preview – examples-nonmonorepo May 13, 2024 20:34 View deployment

vercel bot deployed to Preview – rust-docs May 13, 2024 20:44 View deployment

ForsakenHarmony force-pushed the hrmny/import-attribute-annotations branch from 96a1fee to e0a5a0a Compare May 14, 2024 16:02

vercel bot deployed to Preview – examples-nonmonorepo May 14, 2024 16:03 View deployment

vercel bot deployed to Preview – rust-docs May 14, 2024 16:12 View deployment

ForsakenHarmony marked this pull request as ready for review May 14, 2024 16:43

ForsakenHarmony requested a review from a team as a code owner May 14, 2024 16:43

vercel bot deployed to Preview – examples-nonmonorepo May 14, 2024 18:21 View deployment

ForsakenHarmony force-pushed the hrmny/import-attribute-annotations branch from b2bc908 to 56b6806 Compare May 14, 2024 18:22

vercel bot deployed to Preview – examples-nonmonorepo May 14, 2024 18:23 View deployment

vercel bot deployed to Preview – rust-docs May 14, 2024 18:41 View deployment

ForsakenHarmony commented May 15, 2024

View reviewed changes

ForsakenHarmony force-pushed the hrmny/import-attribute-annotations branch from 56b6806 to 00134d6 Compare May 15, 2024 16:54

vercel bot deployed to Preview – examples-nonmonorepo May 15, 2024 16:54 View deployment

vercel bot deployed to Preview – rust-docs May 15, 2024 17:04 View deployment

ForsakenHarmony and others added 2 commits May 16, 2024 00:12

feat(turbopack-ecmascript): use import attributes for annotations

6250883

add support for type json

2921008

ForsakenHarmony force-pushed the hrmny/import-attribute-annotations branch from 00134d6 to 2921008 Compare May 15, 2024 22:13

vercel bot deployed to Preview – examples-nonmonorepo May 15, 2024 22:13 View deployment

vercel bot deployed to Preview – rust-docs May 15, 2024 22:23 View deployment

ForsakenHarmony merged commit 993891f into main May 16, 2024
46 of 50 checks passed

ForsakenHarmony deleted the hrmny/import-attribute-annotations branch May 16, 2024 00:10

kdy1 mentioned this pull request May 17, 2024

Update turbopack & swc_core vercel/next.js#65450

Merged

Neosoulink pushed a commit to Neosoulink/turbo that referenced this pull request Jun 14, 2024

feat(turbopack-ecmascript): use import attributes for annotations (ve…

77ee752

…rcel#6732)

ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Jul 25, 2024

feat(turbopack-ecmascript): use import attributes for annotations (ve…

8bf005c

…rcel/turborepo#6732)

ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Jul 29, 2024

feat(turbopack-ecmascript): use import attributes for annotations (ve…

9a47032

…rcel/turborepo#6732)

ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Jul 29, 2024

feat(turbopack-ecmascript): use import attributes for annotations (ve…

fe1966f

…rcel/turborepo#6732)

ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Aug 1, 2024

feat(turbopack-ecmascript): use import attributes for annotations (ve…

609181e

…rcel/turborepo#6732)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(turbopack-ecmascript): use import attributes for annotations #6732

feat(turbopack-ecmascript): use import attributes for annotations #6732

ForsakenHarmony commented Dec 7, 2023 •

edited

Loading

vercel bot commented Dec 7, 2023 •

edited

Loading

github-actions bot commented Dec 7, 2023 •

edited

Loading

github-actions bot commented Dec 7, 2023

github-actions bot commented Dec 7, 2023 •

edited

Loading

github-actions bot commented Dec 7, 2023

ForsakenHarmony May 15, 2024

ForsakenHarmony May 15, 2024

ForsakenHarmony commented May 16, 2024

		for (i, rule) in options.await?.rules.iter().enumerate() {
		if has_type_attribute && current_module_type.is_some() {

feat(turbopack-ecmascript): use import attributes for annotations #6732

feat(turbopack-ecmascript): use import attributes for annotations #6732

Conversation

ForsakenHarmony commented Dec 7, 2023 • edited Loading

Description

vercel bot commented Dec 7, 2023 • edited Loading

github-actions bot commented Dec 7, 2023 • edited Loading

🟢 Turbopack Benchmark CI successful 🟢

github-actions bot commented Dec 7, 2023

github-actions bot commented Dec 7, 2023 • edited Loading

⚠️ CI failed ⚠️

github-actions bot commented Dec 7, 2023

Linux Benchmark for 22d3e14

ForsakenHarmony May 15, 2024

Choose a reason for hiding this comment

ForsakenHarmony May 15, 2024

Choose a reason for hiding this comment

ForsakenHarmony commented May 16, 2024

ForsakenHarmony commented Dec 7, 2023 •

edited

Loading

vercel bot commented Dec 7, 2023 •

edited

Loading

github-actions bot commented Dec 7, 2023 •

edited

Loading

github-actions bot commented Dec 7, 2023 •

edited

Loading

Linux Benchmark for `22d3e14`