feat(resolve): skip alias to d.ts #7684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
✅ This change can build |
wbinnssmith
approved these changes
Mar 9, 2024
|
kwonoj
added a commit
to vercel/next.js
that referenced
this pull request
Mar 9, 2024
### What * vercel/turborepo#7684 <!-- OJ Kwon - feat(resolve): skip alias to d.ts --> Closes PACK-2702
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
### Description Simple port to https://github.com/vercel/next.js/pull/11322/files#diff-f80cef26fea96d9530aab29fcaa89b2cc296a54a826a367254997d2885727d33R179. Maybe we can consider to expose this as sort of configuration predicate for specific filter, but the depth of this call is somewhat deep from resolve context and so far there is only one cases (excluding d.ts), so followed same practices to exising next.js behavior. Closes PACK-2701
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description Simple port to https://github.com/vercel/next.js/pull/11322/files#diff-f80cef26fea96d9530aab29fcaa89b2cc296a54a826a367254997d2885727d33R179. Maybe we can consider to expose this as sort of configuration predicate for specific filter, but the depth of this call is somewhat deep from resolve context and so far there is only one cases (excluding d.ts), so followed same practices to exising next.js behavior. Closes PACK-2701
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description Simple port to https://github.com/vercel/next.js/pull/11322/files#diff-f80cef26fea96d9530aab29fcaa89b2cc296a54a826a367254997d2885727d33R179. Maybe we can consider to expose this as sort of configuration predicate for specific filter, but the depth of this call is somewhat deep from resolve context and so far there is only one cases (excluding d.ts), so followed same practices to exising next.js behavior. Closes PACK-2701
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
### Description Simple port to https://github.com/vercel/next.js/pull/11322/files#diff-f80cef26fea96d9530aab29fcaa89b2cc296a54a826a367254997d2885727d33R179. Maybe we can consider to expose this as sort of configuration predicate for specific filter, but the depth of this call is somewhat deep from resolve context and so far there is only one cases (excluding d.ts), so followed same practices to exising next.js behavior. Closes PACK-2701
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simple port to https://github.com/vercel/next.js/pull/11322/files#diff-f80cef26fea96d9530aab29fcaa89b2cc296a54a826a367254997d2885727d33R179.
Maybe we can consider to expose this as sort of configuration predicate for specific filter, but the depth of this call is somewhat deep from resolve context and so far there is only one cases (excluding d.ts), so followed same practices to exising next.js behavior.
Closes PACK-2701