Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RawOutput API #8075

Merged
merged 1 commit into from
May 8, 2024
Merged

Update RawOutput API #8075

merged 1 commit into from
May 8, 2024

Conversation

bgw
Copy link
Member

@bgw bgw commented May 2, 2024

Description

Update RawOutput API

Updated API suggested by @sokra in review on #65223:

vercel/next.js#65223 (comment)

Without this change, I don't think this API is useful. This makes the API very similar to VirtualOutputAsset.

Testing Instructions

Tested with vercel/next.js#65300

Closes PACK-3034

Updated API suggested by @sokra in review on #65223:

vercel/next.js#65223 (comment)

Without this change, I don't think this API is useful. This makes the
API very similar to `VirtualOutputAsset`.
Copy link

vercel bot commented May 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback May 2, 2024 10:55pm
examples-designsystem-docs 🔄 Building (Inspect) Visit Preview May 2, 2024 10:55pm
examples-gatsby-web 🔄 Building (Inspect) Visit Preview May 2, 2024 10:55pm
examples-kitchensink-blog 🔄 Building (Inspect) Visit Preview May 2, 2024 10:55pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2024 10:55pm
examples-tailwind-web 🔄 Building (Inspect) Visit Preview May 2, 2024 10:55pm
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2024 10:55pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-native-web ⬜️ Ignored (Inspect) Visit Preview May 2, 2024 10:55pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview May 2, 2024 10:55pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview May 2, 2024 10:55pm

Copy link
Member Author

bgw commented May 2, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @bgw and the rest of your teammates on Graphite Graphite

Copy link
Contributor

github-actions bot commented May 2, 2024

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Copy link
Contributor

github-actions bot commented May 2, 2024

✅ This change can build next-swc

@bgw bgw changed the title [turbopack] Update RawOutput API Update RawOutput API May 2, 2024
@bgw bgw marked this pull request as ready for review May 2, 2024 22:49
@bgw bgw requested a review from a team as a code owner May 2, 2024 22:49
Copy link
Contributor

github-actions bot commented May 2, 2024

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@bgw bgw merged commit 3e00d0f into main May 8, 2024
48 of 50 checks passed
@bgw bgw deleted the bgw/raw-output branch May 8, 2024 19:27
bgw added a commit to vercel/next.js that referenced this pull request May 22, 2024
Use updated API suggested by sokra in review on #65223:

#65223 (comment)

Depends on vercel/turborepo#8075
Neosoulink pushed a commit to Neosoulink/turbo that referenced this pull request Jun 14, 2024
### Description

Update `RawOutput` API

Updated API suggested by @sokra in review on #65223:

vercel/next.js#65223 (comment)

Without this change, I don't think this API is useful. This makes the API very similar to `VirtualOutputAsset`.

### Testing Instructions

Tested with vercel/next.js#65300

Closes PACK-3034
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
### Description

Update `RawOutput` API

Updated API suggested by @sokra in review on #65223:

#65223 (comment)

Without this change, I don't think this API is useful. This makes the API very similar to `VirtualOutputAsset`.

### Testing Instructions

Tested with #65300

Closes PACK-3034
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
### Description

Update `RawOutput` API

Updated API suggested by @sokra in review on #65223:

#65223 (comment)

Without this change, I don't think this API is useful. This makes the API very similar to `VirtualOutputAsset`.

### Testing Instructions

Tested with #65300

Closes PACK-3034
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
### Description

Update `RawOutput` API

Updated API suggested by @sokra in review on #65223:

#65223 (comment)

Without this change, I don't think this API is useful. This makes the API very similar to `VirtualOutputAsset`.

### Testing Instructions

Tested with #65300

Closes PACK-3034
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
### Description

Update `RawOutput` API

Updated API suggested by @sokra in review on #65223:

#65223 (comment)

Without this change, I don't think this API is useful. This makes the API very similar to `VirtualOutputAsset`.

### Testing Instructions

Tested with #65300

Closes PACK-3034
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 14, 2024
Use updated API suggested by sokra in review on #65223:

#65223 (comment)

Depends on vercel/turborepo#8075
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 15, 2024
Use updated API suggested by sokra in review on #65223:

#65223 (comment)

Depends on vercel/turborepo#8075
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 16, 2024
Use updated API suggested by sokra in review on #65223:

#65223 (comment)

Depends on vercel/turborepo#8075
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants