-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update RawOutput API #8075
Merged
Merged
Update RawOutput API #8075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated API suggested by @sokra in review on #65223: vercel/next.js#65223 (comment) Without this change, I don't think this API is useful. This makes the API very similar to `VirtualOutputAsset`.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
🟢 Turbopack Benchmark CI successful 🟢Thanks |
✅ This change can build |
|
sokra
approved these changes
May 8, 2024
bgw
added a commit
to vercel/next.js
that referenced
this pull request
May 22, 2024
Use updated API suggested by sokra in review on #65223: #65223 (comment) Depends on vercel/turborepo#8075
Neosoulink
pushed a commit
to Neosoulink/turbo
that referenced
this pull request
Jun 14, 2024
### Description Update `RawOutput` API Updated API suggested by @sokra in review on #65223: vercel/next.js#65223 (comment) Without this change, I don't think this API is useful. This makes the API very similar to `VirtualOutputAsset`. ### Testing Instructions Tested with vercel/next.js#65300 Closes PACK-3034
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
### Description Update `RawOutput` API Updated API suggested by @sokra in review on #65223: #65223 (comment) Without this change, I don't think this API is useful. This makes the API very similar to `VirtualOutputAsset`. ### Testing Instructions Tested with #65300 Closes PACK-3034
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description Update `RawOutput` API Updated API suggested by @sokra in review on #65223: #65223 (comment) Without this change, I don't think this API is useful. This makes the API very similar to `VirtualOutputAsset`. ### Testing Instructions Tested with #65300 Closes PACK-3034
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description Update `RawOutput` API Updated API suggested by @sokra in review on #65223: #65223 (comment) Without this change, I don't think this API is useful. This makes the API very similar to `VirtualOutputAsset`. ### Testing Instructions Tested with #65300 Closes PACK-3034
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
### Description Update `RawOutput` API Updated API suggested by @sokra in review on #65223: #65223 (comment) Without this change, I don't think this API is useful. This makes the API very similar to `VirtualOutputAsset`. ### Testing Instructions Tested with #65300 Closes PACK-3034
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 14, 2024
Use updated API suggested by sokra in review on #65223: #65223 (comment) Depends on vercel/turborepo#8075
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 15, 2024
Use updated API suggested by sokra in review on #65223: #65223 (comment) Depends on vercel/turborepo#8075
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 16, 2024
Use updated API suggested by sokra in review on #65223: #65223 (comment) Depends on vercel/turborepo#8075
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update
RawOutput
APIUpdated API suggested by @sokra in review on #65223:
vercel/next.js#65223 (comment)
Without this change, I don't think this API is useful. This makes the API very similar to
VirtualOutputAsset
.Testing Instructions
Tested with vercel/next.js#65300
Closes PACK-3034