-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor memory tracking #8130
refactor memory tracking #8130
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Ignored Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
✅ This change can build |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the thread local nature of with_local_counter
is going to cause problems if/when work stealing happens.
refactor memory for tracing track memory for tasks
5e4a4e0
to
6f6ae57
Compare
It reads the allocation counters before and after every poll, and only keeps the diff. So that should be fine. |
added not send for allocation counters |
### What? * vercel/turborepo#8101 <!-- Tobias Koppers - fix off-by-one bug while reading heaptrack files --> * vercel/turborepo#8130 <!-- Tobias Koppers - refactor memory tracking --> * vercel/turborepo#8097 <!-- Donny/강동윤 - build: Update `swc_core` to `v0.92.5` --> Update swc_core. ### Why? To keep in sync and fix styled-jsx issues ### How? Closes PACK-3042 --------- Co-authored-by: hrmny <8845940+ForsakenHarmony@users.noreply.github.com>
### Description refactor memory for tracing track memory for tasks ### Testing Instructions <!-- Give a quick description of steps to test your changes. -->
### Description refactor memory for tracing track memory for tasks ### Testing Instructions <!-- Give a quick description of steps to test your changes. -->
### Description refactor memory for tracing track memory for tasks ### Testing Instructions <!-- Give a quick description of steps to test your changes. -->
### Description refactor memory for tracing track memory for tasks ### Testing Instructions <!-- Give a quick description of steps to test your changes. -->
### Description refactor memory for tracing track memory for tasks ### Testing Instructions <!-- Give a quick description of steps to test your changes. -->
* vercel/turborepo#8101 <!-- Tobias Koppers - fix off-by-one bug while reading heaptrack files --> * vercel/turborepo#8130 <!-- Tobias Koppers - refactor memory tracking --> * vercel/turborepo#8097 <!-- Donny/강동윤 - build: Update `swc_core` to `v0.92.5` --> Update swc_core. To keep in sync and fix styled-jsx issues Closes PACK-3042 --------- Co-authored-by: hrmny <8845940+ForsakenHarmony@users.noreply.github.com>
* vercel/turborepo#8101 <!-- Tobias Koppers - fix off-by-one bug while reading heaptrack files --> * vercel/turborepo#8130 <!-- Tobias Koppers - refactor memory tracking --> * vercel/turborepo#8097 <!-- Donny/강동윤 - build: Update `swc_core` to `v0.92.5` --> Update swc_core. To keep in sync and fix styled-jsx issues Closes PACK-3042 --------- Co-authored-by: hrmny <8845940+ForsakenHarmony@users.noreply.github.com>
### What? * vercel/turborepo#8101 <!-- Tobias Koppers - fix off-by-one bug while reading heaptrack files --> * vercel/turborepo#8130 <!-- Tobias Koppers - refactor memory tracking --> * vercel/turborepo#8097 <!-- Donny/강동윤 - build: Update `swc_core` to `v0.92.5` --> Update swc_core. ### Why? To keep in sync and fix styled-jsx issues ### How? Closes PACK-3042 --------- Co-authored-by: hrmny <8845940+ForsakenHarmony@users.noreply.github.com>
Description
refactor memory for tracing
track memory for tasks
Testing Instructions