Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor memory tracking #8130

Merged
merged 3 commits into from
May 16, 2024
Merged

refactor memory tracking #8130

merged 3 commits into from
May 16, 2024

Conversation

sokra
Copy link
Member

@sokra sokra commented May 13, 2024

Description

refactor memory for tracing
track memory for tasks

Testing Instructions

@sokra sokra requested a review from a team as a code owner May 13, 2024 11:52
Copy link

vercel bot commented May 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-designsystem-docs 🔄 Building (Inspect) Visit Preview 💬 Add feedback May 16, 2024 9:23am
examples-gatsby-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback May 16, 2024 9:23am
examples-kitchensink-blog 🔄 Building (Inspect) Visit Preview 💬 Add feedback May 16, 2024 9:23am
examples-native-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback May 16, 2024 9:23am
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 9:23am
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 9:23am
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview May 16, 2024 9:23am
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview May 16, 2024 9:23am
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview May 16, 2024 9:23am
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview May 16, 2024 9:23am

Copy link
Contributor

github-actions bot commented May 13, 2024

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Copy link
Contributor

✅ This change can build next-swc

Copy link
Contributor

github-actions bot commented May 13, 2024

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

Copy link
Member

@bgw bgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the thread local nature of with_local_counter is going to cause problems if/when work stealing happens.

refactor memory for tracing
track memory for tasks
@sokra
Copy link
Member Author

sokra commented May 16, 2024

I think the thread local nature of with_local_counter is going to cause problems if/when work stealing happens.

It reads the allocation counters before and after every poll, and only keeps the diff. So that should be fine.

@sokra sokra requested a review from bgw May 16, 2024 09:20
@sokra
Copy link
Member Author

sokra commented May 16, 2024

added not send for allocation counters

@sokra sokra merged commit 829012c into main May 16, 2024
48 of 50 checks passed
@sokra sokra deleted the sokra/memory-tracking branch May 16, 2024 21:13
sokra pushed a commit to vercel/next.js that referenced this pull request May 17, 2024
### What?

* vercel/turborepo#8101 <!-- Tobias Koppers - fix
off-by-one bug while reading heaptrack files -->
* vercel/turborepo#8130 <!-- Tobias Koppers -
refactor memory tracking -->
* vercel/turborepo#8097 <!-- Donny/강동윤 - build:
Update `swc_core` to `v0.92.5` -->

Update swc_core.


### Why?

To keep in sync and fix styled-jsx issues

### How?

Closes PACK-3042

---------

Co-authored-by: hrmny <8845940+ForsakenHarmony@users.noreply.github.com>
Neosoulink pushed a commit to Neosoulink/turbo that referenced this pull request Jun 14, 2024
### Description

refactor memory for tracing
track memory for tasks

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
### Description

refactor memory for tracing
track memory for tasks

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
### Description

refactor memory for tracing
track memory for tasks

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
### Description

refactor memory for tracing
track memory for tasks

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
### Description

refactor memory for tracing
track memory for tasks

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Aug 14, 2024
* vercel/turborepo#8101 <!-- Tobias Koppers - fix
off-by-one bug while reading heaptrack files -->
* vercel/turborepo#8130 <!-- Tobias Koppers -
refactor memory tracking -->
* vercel/turborepo#8097 <!-- Donny/강동윤 - build:
Update `swc_core` to `v0.92.5` -->

Update swc_core.

To keep in sync and fix styled-jsx issues

Closes PACK-3042

---------

Co-authored-by: hrmny <8845940+ForsakenHarmony@users.noreply.github.com>
ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Aug 15, 2024
* vercel/turborepo#8101 <!-- Tobias Koppers - fix
off-by-one bug while reading heaptrack files -->
* vercel/turborepo#8130 <!-- Tobias Koppers -
refactor memory tracking -->
* vercel/turborepo#8097 <!-- Donny/강동윤 - build:
Update `swc_core` to `v0.92.5` -->

Update swc_core.

To keep in sync and fix styled-jsx issues

Closes PACK-3042

---------

Co-authored-by: hrmny <8845940+ForsakenHarmony@users.noreply.github.com>
ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Aug 16, 2024
### What?

* vercel/turborepo#8101 <!-- Tobias Koppers - fix
off-by-one bug while reading heaptrack files -->
* vercel/turborepo#8130 <!-- Tobias Koppers -
refactor memory tracking -->
* vercel/turborepo#8097 <!-- Donny/강동윤 - build:
Update `swc_core` to `v0.92.5` -->

Update swc_core.


### Why?

To keep in sync and fix styled-jsx issues

### How?

Closes PACK-3042

---------

Co-authored-by: hrmny <8845940+ForsakenHarmony@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants