Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ast-grep GitHub action and pin versions #8275

Closed
wants to merge 7 commits into from

Conversation

wbinnssmith
Copy link
Member

This uses the official ast-grep GitHub Action [0] instead of installing it from npm in the clippy job.

Thanks for the suggestion from @HerringtonDarkholme!

[0] https://github.com/ast-grep/action
[1] #5637 (comment)

@wbinnssmith wbinnssmith requested review from a team as code owners June 3, 2024 16:40
Copy link

vercel bot commented Jun 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2024 6:00pm
9 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Jun 12, 2024 6:00pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Jun 12, 2024 6:00pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Jun 12, 2024 6:00pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Jun 12, 2024 6:00pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Jun 12, 2024 6:00pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Jun 12, 2024 6:00pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Jun 12, 2024 6:00pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Jun 12, 2024 6:00pm
rust-docs ⬜️ Ignored (Inspect) Visit Preview Jun 12, 2024 6:00pm

Copy link
Contributor

github-actions bot commented Jun 3, 2024

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Copy link
Contributor

github-actions bot commented Jun 3, 2024

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)
  • Turbopack Rust benchmark tests (linux)
  • Turbopack Rust benchmark tests (mac/win, non-blocking)

See workflow summary for details

Copy link
Contributor

✅ This change can build next-swc

This uses the official ast-grep GitHub Action [0] instead of installing it from npm in the clippy job.

Thanks for the suggestion from @HerringtonDarkholme!

[0] https://github.com/ast-grep/action
[1] #5637 (comment)
@HerringtonDarkholme
Copy link

Hi! I have also published v1.6 to include the new path argument in action. Let me know if it works for you.

@wbinnssmith wbinnssmith marked this pull request as draft June 11, 2024 22:56
@wbinnssmith
Copy link
Member Author

wbinnssmith commented Jun 12, 2024

Hi! I have also published v1.6 to include the new path argument in action. Let me know if it works for you.

@HerringtonDarkholme It looks like the action has stale dist and needs an npm run build 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants