Add u64 ExecutionId type #8771
Merged
Add u64 ExecutionId type #8771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
✅ This change can build |
|
sokra
approved these changes
Jul 17, 2024
bgw
added a commit
that referenced
this pull request
Jul 17, 2024
### Description The real goal here was to extend `IdFactory<T>` to work with 64-bit ids, which I'll need soon for globally unique (and non-reusable) "execution ids" (#8771) to support the safety requirements of local uncached Vcs. I got a little carried away and essentially rewrote this: - (Debatable if this is an improvement or not) ID generation re-use requires an almost-but-not-entirely-free check of the concurrent queue, so it is now opt-in using the `IdFactoryWithReuse`. - ID generation is always performed with an AtomicU64 (which shouldn't really be any more or less expensive than AtomicU32 on 64 bit architectures). - u32 overflow detection is performed by using a `TryFrom` conversion from a NonZeroU64. Previously we could only detect and panic on the first id generated after overflow. Now we should detect and panic on (basically) all ids generated after overflow. - New versions of `concurrent-queue` make the `unbounded` constructor `const`, which allows us to eliminate the use of `Lazy`. - Add a unit test for overflow detection ### Testing Instructions ``` cargo nextest r -p turbo-tasks -p turbo-tasks-memory ```
bgw
force-pushed
the
bgw/execution-id-type
branch
from
90a3fd2 to
1a00797
Compare
bgw
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 18, 2024
* vercel/turborepo#8767 <!-- Niklas Mischkulnig - Update Turbopack members in labeler --> * vercel/turborepo#8722 <!-- Niklas Mischkulnig - Use fs and vm for async chunk loading in Node --> * vercel/turborepo#8758 <!-- Benjamin Woodruff - Remove unused instant return value from `CaptureFuture` --> * vercel/turborepo#8760 <!-- Benjamin Woodruff - Delete dead raw_vc_set module --> * vercel/turborepo#8761 <!-- Benjamin Woodruff - Delete dead keyed_cell module --> * vercel/turborepo#8755 <!-- Donny/강동윤 - feat: Enable tree shaking in next.js --> * vercel/turborepo#8769 <!-- Benjamin Woodruff - Rewrite IdFactory and IdFactoryWithReuse --> * vercel/turborepo#8771 <!-- Benjamin Woodruff - Add u64 ExecutionId type --> * vercel/turborepo#8735 <!-- Tobias Koppers - turbo-tasks this calls --> * vercel/turborepo#8775 <!-- Tobias Koppers - improve failsafe_analyse --> * vercel/turborepo#8776 <!-- Tobias Koppers - notify tasks when collectibles change --> * vercel/turborepo#8778 <!-- Tobias Koppers - fix collectibles counting --> * vercel/turborepo#8736 <!-- Tobias Koppers - Refactor task arguments to be a single one --> * vercel/turborepo#8737 <!-- Tobias Koppers - remove ConcreteTaskInput in favor of the original rust datatypes -->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
### Description The real goal here was to extend `IdFactory<T>` to work with 64-bit ids, which I'll need soon for globally unique (and non-reusable) "execution ids" (vercel/turborepo#8771) to support the safety requirements of local uncached Vcs. I got a little carried away and essentially rewrote this: - (Debatable if this is an improvement or not) ID generation re-use requires an almost-but-not-entirely-free check of the concurrent queue, so it is now opt-in using the `IdFactoryWithReuse`. - ID generation is always performed with an AtomicU64 (which shouldn't really be any more or less expensive than AtomicU32 on 64 bit architectures). - u32 overflow detection is performed by using a `TryFrom` conversion from a NonZeroU64. Previously we could only detect and panic on the first id generated after overflow. Now we should detect and panic on (basically) all ids generated after overflow. - New versions of `concurrent-queue` make the `unbounded` constructor `const`, which allows us to eliminate the use of `Lazy`. - Add a unit test for overflow detection ### Testing Instructions ``` cargo nextest r -p turbo-tasks -p turbo-tasks-memory ```
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
### Description
The plan for task-local Vcs is to extend the `RawVc` type into:
```
enum RawVc {
TaskOutput(TaskId),
TaskCell(TaskId, CellId),
LocalCell(ExecutionId, LocalCellId), // new variant!
}
```
Where `ExecutionId` is a globally unique value representing the current task execution. That will be used with runtime safety checks to ensure that a given `LocalCellId` (which is an index into a task-local arena/vec) is valid upon read.
https://www.notion.so/vercel/Resolved-Vcs-Vc-Lifetimes-Local-Vcs-and-Vc-Refcounts-49d666d3f9594017b5b312b87ddc5bff?pvs=4
This PR extends the `define_id` macro to support arbitrary integer types, and uses that to define `ExecutionId`.
### Testing Instructions
```
cargo nextest r -p turbo-tasks -p turbo-tasks-memory
```
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description The real goal here was to extend `IdFactory<T>` to work with 64-bit ids, which I'll need soon for globally unique (and non-reusable) "execution ids" (vercel/turborepo#8771) to support the safety requirements of local uncached Vcs. I got a little carried away and essentially rewrote this: - (Debatable if this is an improvement or not) ID generation re-use requires an almost-but-not-entirely-free check of the concurrent queue, so it is now opt-in using the `IdFactoryWithReuse`. - ID generation is always performed with an AtomicU64 (which shouldn't really be any more or less expensive than AtomicU32 on 64 bit architectures). - u32 overflow detection is performed by using a `TryFrom` conversion from a NonZeroU64. Previously we could only detect and panic on the first id generated after overflow. Now we should detect and panic on (basically) all ids generated after overflow. - New versions of `concurrent-queue` make the `unbounded` constructor `const`, which allows us to eliminate the use of `Lazy`. - Add a unit test for overflow detection ### Testing Instructions ``` cargo nextest r -p turbo-tasks -p turbo-tasks-memory ```
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description
The plan for task-local Vcs is to extend the `RawVc` type into:
```
enum RawVc {
TaskOutput(TaskId),
TaskCell(TaskId, CellId),
LocalCell(ExecutionId, LocalCellId), // new variant!
}
```
Where `ExecutionId` is a globally unique value representing the current task execution. That will be used with runtime safety checks to ensure that a given `LocalCellId` (which is an index into a task-local arena/vec) is valid upon read.
https://www.notion.so/vercel/Resolved-Vcs-Vc-Lifetimes-Local-Vcs-and-Vc-Refcounts-49d666d3f9594017b5b312b87ddc5bff?pvs=4
This PR extends the `define_id` macro to support arbitrary integer types, and uses that to define `ExecutionId`.
### Testing Instructions
```
cargo nextest r -p turbo-tasks -p turbo-tasks-memory
```
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description The real goal here was to extend `IdFactory<T>` to work with 64-bit ids, which I'll need soon for globally unique (and non-reusable) "execution ids" (vercel/turborepo#8771) to support the safety requirements of local uncached Vcs. I got a little carried away and essentially rewrote this: - (Debatable if this is an improvement or not) ID generation re-use requires an almost-but-not-entirely-free check of the concurrent queue, so it is now opt-in using the `IdFactoryWithReuse`. - ID generation is always performed with an AtomicU64 (which shouldn't really be any more or less expensive than AtomicU32 on 64 bit architectures). - u32 overflow detection is performed by using a `TryFrom` conversion from a NonZeroU64. Previously we could only detect and panic on the first id generated after overflow. Now we should detect and panic on (basically) all ids generated after overflow. - New versions of `concurrent-queue` make the `unbounded` constructor `const`, which allows us to eliminate the use of `Lazy`. - Add a unit test for overflow detection ### Testing Instructions ``` cargo nextest r -p turbo-tasks -p turbo-tasks-memory ```
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description
The plan for task-local Vcs is to extend the `RawVc` type into:
```
enum RawVc {
TaskOutput(TaskId),
TaskCell(TaskId, CellId),
LocalCell(ExecutionId, LocalCellId), // new variant!
}
```
Where `ExecutionId` is a globally unique value representing the current task execution. That will be used with runtime safety checks to ensure that a given `LocalCellId` (which is an index into a task-local arena/vec) is valid upon read.
https://www.notion.so/vercel/Resolved-Vcs-Vc-Lifetimes-Local-Vcs-and-Vc-Refcounts-49d666d3f9594017b5b312b87ddc5bff?pvs=4
This PR extends the `define_id` macro to support arbitrary integer types, and uses that to define `ExecutionId`.
### Testing Instructions
```
cargo nextest r -p turbo-tasks -p turbo-tasks-memory
```
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
### Description The real goal here was to extend `IdFactory<T>` to work with 64-bit ids, which I'll need soon for globally unique (and non-reusable) "execution ids" (vercel/turborepo#8771) to support the safety requirements of local uncached Vcs. I got a little carried away and essentially rewrote this: - (Debatable if this is an improvement or not) ID generation re-use requires an almost-but-not-entirely-free check of the concurrent queue, so it is now opt-in using the `IdFactoryWithReuse`. - ID generation is always performed with an AtomicU64 (which shouldn't really be any more or less expensive than AtomicU32 on 64 bit architectures). - u32 overflow detection is performed by using a `TryFrom` conversion from a NonZeroU64. Previously we could only detect and panic on the first id generated after overflow. Now we should detect and panic on (basically) all ids generated after overflow. - New versions of `concurrent-queue` make the `unbounded` constructor `const`, which allows us to eliminate the use of `Lazy`. - Add a unit test for overflow detection ### Testing Instructions ``` cargo nextest r -p turbo-tasks -p turbo-tasks-memory ```
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
### Description
The plan for task-local Vcs is to extend the `RawVc` type into:
```
enum RawVc {
TaskOutput(TaskId),
TaskCell(TaskId, CellId),
LocalCell(ExecutionId, LocalCellId), // new variant!
}
```
Where `ExecutionId` is a globally unique value representing the current task execution. That will be used with runtime safety checks to ensure that a given `LocalCellId` (which is an index into a task-local arena/vec) is valid upon read.
https://www.notion.so/vercel/Resolved-Vcs-Vc-Lifetimes-Local-Vcs-and-Vc-Refcounts-49d666d3f9594017b5b312b87ddc5bff?pvs=4
This PR extends the `define_id` macro to support arbitrary integer types, and uses that to define `ExecutionId`.
### Testing Instructions
```
cargo nextest r -p turbo-tasks -p turbo-tasks-memory
```
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 14, 2024
* vercel/turborepo#8767 <!-- Niklas Mischkulnig - Update Turbopack members in labeler --> * vercel/turborepo#8722 <!-- Niklas Mischkulnig - Use fs and vm for async chunk loading in Node --> * vercel/turborepo#8758 <!-- Benjamin Woodruff - Remove unused instant return value from `CaptureFuture` --> * vercel/turborepo#8760 <!-- Benjamin Woodruff - Delete dead raw_vc_set module --> * vercel/turborepo#8761 <!-- Benjamin Woodruff - Delete dead keyed_cell module --> * vercel/turborepo#8755 <!-- Donny/강동윤 - feat: Enable tree shaking in next.js --> * vercel/turborepo#8769 <!-- Benjamin Woodruff - Rewrite IdFactory and IdFactoryWithReuse --> * vercel/turborepo#8771 <!-- Benjamin Woodruff - Add u64 ExecutionId type --> * vercel/turborepo#8735 <!-- Tobias Koppers - turbo-tasks this calls --> * vercel/turborepo#8775 <!-- Tobias Koppers - improve failsafe_analyse --> * vercel/turborepo#8776 <!-- Tobias Koppers - notify tasks when collectibles change --> * vercel/turborepo#8778 <!-- Tobias Koppers - fix collectibles counting --> * vercel/turborepo#8736 <!-- Tobias Koppers - Refactor task arguments to be a single one --> * vercel/turborepo#8737 <!-- Tobias Koppers - remove ConcreteTaskInput in favor of the original rust datatypes -->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 15, 2024
* vercel/turborepo#8767 <!-- Niklas Mischkulnig - Update Turbopack members in labeler --> * vercel/turborepo#8722 <!-- Niklas Mischkulnig - Use fs and vm for async chunk loading in Node --> * vercel/turborepo#8758 <!-- Benjamin Woodruff - Remove unused instant return value from `CaptureFuture` --> * vercel/turborepo#8760 <!-- Benjamin Woodruff - Delete dead raw_vc_set module --> * vercel/turborepo#8761 <!-- Benjamin Woodruff - Delete dead keyed_cell module --> * vercel/turborepo#8755 <!-- Donny/강동윤 - feat: Enable tree shaking in next.js --> * vercel/turborepo#8769 <!-- Benjamin Woodruff - Rewrite IdFactory and IdFactoryWithReuse --> * vercel/turborepo#8771 <!-- Benjamin Woodruff - Add u64 ExecutionId type --> * vercel/turborepo#8735 <!-- Tobias Koppers - turbo-tasks this calls --> * vercel/turborepo#8775 <!-- Tobias Koppers - improve failsafe_analyse --> * vercel/turborepo#8776 <!-- Tobias Koppers - notify tasks when collectibles change --> * vercel/turborepo#8778 <!-- Tobias Koppers - fix collectibles counting --> * vercel/turborepo#8736 <!-- Tobias Koppers - Refactor task arguments to be a single one --> * vercel/turborepo#8737 <!-- Tobias Koppers - remove ConcreteTaskInput in favor of the original rust datatypes -->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 16, 2024
* vercel/turborepo#8767 <!-- Niklas Mischkulnig - Update Turbopack members in labeler --> * vercel/turborepo#8722 <!-- Niklas Mischkulnig - Use fs and vm for async chunk loading in Node --> * vercel/turborepo#8758 <!-- Benjamin Woodruff - Remove unused instant return value from `CaptureFuture` --> * vercel/turborepo#8760 <!-- Benjamin Woodruff - Delete dead raw_vc_set module --> * vercel/turborepo#8761 <!-- Benjamin Woodruff - Delete dead keyed_cell module --> * vercel/turborepo#8755 <!-- Donny/강동윤 - feat: Enable tree shaking in next.js --> * vercel/turborepo#8769 <!-- Benjamin Woodruff - Rewrite IdFactory and IdFactoryWithReuse --> * vercel/turborepo#8771 <!-- Benjamin Woodruff - Add u64 ExecutionId type --> * vercel/turborepo#8735 <!-- Tobias Koppers - turbo-tasks this calls --> * vercel/turborepo#8775 <!-- Tobias Koppers - improve failsafe_analyse --> * vercel/turborepo#8776 <!-- Tobias Koppers - notify tasks when collectibles change --> * vercel/turborepo#8778 <!-- Tobias Koppers - fix collectibles counting --> * vercel/turborepo#8736 <!-- Tobias Koppers - Refactor task arguments to be a single one --> * vercel/turborepo#8737 <!-- Tobias Koppers - remove ConcreteTaskInput in favor of the original rust datatypes -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The plan for task-local Vcs is to extend the
RawVctype into:Where
ExecutionIdis a globally unique value representing the current task execution. That will be used with runtime safety checks to ensure that a givenLocalCellId(which is an index into a task-local arena/vec) is valid upon read.https://www.notion.so/vercel/Resolved-Vcs-Vc-Lifetimes-Local-Vcs-and-Vc-Refcounts-49d666d3f9594017b5b312b87ddc5bff?pvs=4
This PR extends the
define_idmacro to support arbitrary integer types, and uses that to defineExecutionId.Testing Instructions