Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add peer dependencies to eslint packages #8773

Merged
merged 7 commits into from
Nov 29, 2024

Conversation

bitttttten
Copy link
Contributor

Description

This adds peer dependencies to the eslint config and eslint plugin to help with errors like #5571 (comment).

When upgrading turbo, you can run into errors even when using codemod since the codemod doesn't update these modules.

@bitttttten bitttttten requested a review from a team as a code owner July 17, 2024 14:59
@turbo-orchestrator turbo-orchestrator bot added needs: triage New issues get this label. Remove it after triage owned-by: turborepo pkg: turbo-eslint eslint-config-turbo and eslint-plugin-turbo labels Jul 17, 2024
@bitttttten bitttttten changed the title improv: add peer dependencies to turbo improv: add peer dependencies to eslint packages Jul 17, 2024
Copy link

vercel bot commented Jul 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 29, 2024 9:12pm
8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Nov 29, 2024 9:12pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Nov 29, 2024 9:12pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Nov 29, 2024 9:12pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Nov 29, 2024 9:12pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Nov 29, 2024 9:12pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Nov 29, 2024 9:12pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Nov 29, 2024 9:12pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Nov 29, 2024 9:12pm

Copy link

vercel bot commented Jul 17, 2024

@bitttttten is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@anthonyshew anthonyshew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

@anthonyshew
Copy link
Contributor

We'll need to update the lockfile to agree with these changes. Could you run pnpm install to get it fixed up and push those changes?

@bitttttten
Copy link
Contributor Author

@anthonyshew I also had some other parts of the pnpm-lock file that I did know wether to commit or not:

@@ -11156,6 +11162,66 @@ packages:
     engines: {node: '>=0.6.11 <=0.7.0 || >=0.7.3'}
     dev: false

+  /turbo-darwin-64@2.3.0:
+    resolution: {integrity: sha512-pji+D49PhFItyQjf2QVoLZw2d3oRGo8gJgKyOiRzvip78Rzie74quA8XNwSg/DuzM7xx6gJ3p2/LylTTlgZXxQ==}
+    cpu: [x64]
+    os: [darwin]
+    requiresBuild: true
+    dev: false
+    optional: true
+
+  /turbo-darwin-arm64@2.3.0:
+    resolution: {integrity: sha512-AJrGIL9BO41mwDF/IBHsNGwvtdyB911vp8f5mbNo1wG66gWTvOBg7WCtYQBvCo11XTenTfXPRSsAb7w3WAZb6w==}
+    cpu: [arm64]
+    os: [darwin]
+    requiresBuild: true
+    dev: false
+    optional: true
+
+  /turbo-linux-64@2.3.0:
+    resolution: {integrity: sha512-jZqW6vc2sPJT3M/3ZmV1Cg4ecQVPqsbHncG/RnogHpBu783KCSXIndgxvUQNm9qfgBYbZDBnP1md63O4UTElhw==}
+    cpu: [x64]
+    os: [linux]
+    requiresBuild: true
+    dev: false
+    optional: true
+
+  /turbo-linux-arm64@2.3.0:
+    resolution: {integrity: sha512-HUbDLJlvd/hxuyCNO0BmEWYQj0TugRMvSQeG8vHJH+Lq8qOgDAe7J0K73bFNbZejZQxW3C3XEiZFB3pnpO78+A==}
+    cpu: [arm64]
+    os: [linux]
+    requiresBuild: true
+    dev: false
+    optional: true
+
+  /turbo-windows-64@2.3.0:
+    resolution: {integrity: sha512-c5rxrGNTYDWX9QeMzWLFE9frOXnKjHGEvQMp1SfldDlbZYsloX9UKs31TzUThzfTgTiz8NYuShaXJ2UvTMnV/g==}
+    cpu: [x64]
+    os: [win32]
+    requiresBuild: true
+    dev: false
+    optional: true
+
+  /turbo-windows-arm64@2.3.0:
+    resolution: {integrity: sha512-7qfUuYhfIVb1AZgs89DxhXK+zZez6O2ocmixEQ4hXZK7ytnBt5vaz2zGNJJKFNYIL5HX1C3tuHolnpNgDNCUIg==}
+    cpu: [arm64]
+    os: [win32]
+    requiresBuild: true
+    dev: false
+    optional: true
+
+  /turbo@2.3.0:
+    resolution: {integrity: sha512-/uOq5o2jwRPyaUDnwBpOR5k9mQq4c3wziBgWNWttiYQPmbhDtrKYPRBxTvA2WpgQwRIbt8UM612RMN8n/TvmHA==}
+    hasBin: true
+    optionalDependencies:
+      turbo-darwin-64: 2.3.0
+      turbo-darwin-arm64: 2.3.0
+      turbo-linux-64: 2.3.0
+      turbo-linux-arm64: 2.3.0
+      turbo-windows-64: 2.3.0
+      turbo-windows-arm64: 2.3.0
+    dev: false
+
   /type-check@0.3.2:
     resolution: {integrity: sha512-ZCmOJdvOWDBYJlzAoFkC+Q0+bUyEOS1ltgp1MGU03fqHG+dbi9tBFU2Rd9QKiDZFAYrhPh2JUf7rZRIuHRKtOg==}
     engines: {node: '>= 0.8.0'}
(3/3) Stage this hunk [y,n,q,a,d,K,g,/,e,?]? n

I didn't stage this part of the lock file, I am not sure if it was totally correct or not. Let me know if you want me to also stage this part.

@anthonyshew
Copy link
Contributor

Yes. Otherwise, installation will still fail. Bumped Ci to run to show that, as you can see.

@bitttttten
Copy link
Contributor Author

Okay thanks, pnpm is new to me 🐥
When I get home in an hour or so i can push the rest of the lockfile

Copy link

@orca-security-us orca-security-us bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Failed Failed Secrets high 2   medium 0   low 0   info 0 View in Orca
🔑 The following Secrets have been detected in your pull request across all commits

⚠️ Please take action to mitigate the risk of the identified secrets by revoking them, and if already in use, updating all dependent systems

NAME FILE LINE NUM COMMIT
high TinyBird Token .../generators/utils.ts 10 0f6cd6a View in code
high TinyBird Token ...orepoMinutesSaved.ts 7 88b8c5f View in code

@bitttttten
Copy link
Contributor Author

Thanks for your patience @anthonyshew , the lock file has been updated.

@anthonyshew anthonyshew merged commit e901df6 into vercel:main Nov 29, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: triage New issues get this label. Remove it after triage pkg: turbo-eslint eslint-config-turbo and eslint-plugin-turbo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants