-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(query): add array type #9161
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
crates/turborepo-lib/src/query.rs
Outdated
unsafe impl<T: Send + OutputType> Send for Array<T> {} | ||
unsafe impl<T: Sync + OutputType> Sync for Array<T> {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these necessary? Rust should be automatically implementing these if all fields are Send
/Sync
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing this to approve to unblock, but I do think that the unsafe impl
s should be removed.
5d1c76f
to
ed1961e
Compare
Description
Added an
Array
type that automatically adds alength
anditems
field to GraphQL responses.Testing Instructions