Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update using-environment-variables.mdx formatting to remove extra p tag #9168

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

dimitropoulos
Copy link
Contributor

@dimitropoulos dimitropoulos commented Sep 18, 2024

Description

The formatter hurt us here. Here's what I originally wrote and tested:

Code Website DOM
Screenshot_20240918_184346 Screenshot_20240918_184612 Screenshot_20240918_184433

But here's what happens with this seemingly insignificant formatting change that I wasn't aware would affect the rendered output and didn't test.

Code Website DOM
Screenshot_20240918_184037 Screenshot_20240918_184659 Screenshot_20240918_184235

See what happens? An extra p tag gets shoved in there when it's formatted. No idea why. Sounds like a bug in the markdown renderer, honestly.

Testing Instructions

Check the preview link.

Copy link

vercel bot commented Sep 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 18, 2024 10:48pm
8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Sep 18, 2024 10:48pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Sep 18, 2024 10:48pm
examples-gatsby-web ⬜️ Ignored (Inspect) Sep 18, 2024 10:48pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Sep 18, 2024 10:48pm
examples-native-web ⬜️ Ignored (Inspect) Sep 18, 2024 10:48pm
examples-svelte-web ⬜️ Ignored (Inspect) Sep 18, 2024 10:48pm
examples-tailwind-web ⬜️ Ignored (Inspect) Sep 18, 2024 10:48pm
examples-vite-web ⬜️ Ignored (Inspect) Sep 18, 2024 10:48pm

@turbo-orchestrator turbo-orchestrator bot added area: docs Improvements or additions to documentation created-by: turborepo labels Sep 18, 2024
Copy link
Contributor

Hi there 👋

It looks like this PR introduces broken links to the docs, please take a moment to fix them before merging:

Broken link Type File
/repo/docs/guides/tools/typescript#you-likely-dont-need-a-tsconfigjson-file-in-the-root-of-your-project hash /repo-docs/crafting-your-repository/structuring-a-repository.mdx
#package-entrypoint-wildcards hash /repo-docs/guides/tools/typescript.mdx

Thank you 🙏

@dimitropoulos dimitropoulos merged commit 98ad530 into main Sep 19, 2024
39 of 40 checks passed
@dimitropoulos dimitropoulos deleted the dimitropoulos-patch-1 branch September 19, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants