fix(affected): consider both source and destination as changed #9422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
chris-olszewski
commented
Nov 12, 2024
| None, | ||
| false, | ||
| )?; | ||
| assert_eq!(files, HashSet::new()); |
There was a problem hiding this comment.
Before this PR, this assertion would fail as files would contain bar.js
tknickman
approved these changes
Nov 20, 2024
chris-olszewski
deleted the
chrisolszewski/turbo-4103-affectedpackages-doesnt-include-the
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously we would only consider the destination file moved as changed and not the source. We use
diff-treeinstead ofdiffto track these moves.This PR also fixes an issue where
include_uncommitted: falsewas not respected ifto_commitwasn't present i.e. we would always return uncommitted changes. This did not affect users since this API isn't exposed to users and there's no way to setinclude_uncommitted: falsewithout setting ato_commit.Testing Instructions
Added unit test where a file is moved between packages. Also added additional checks for our
changed_filestests