Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tui): persistent preferences #9512

Merged
merged 27 commits into from
Dec 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ Thank you for your interest in contributing to Turborepo!
- [Manually testing `turbo`](#manually-testing-turbo)
- [Repositories to test with](#repositories-to-test-with)
- [Debugging tips](#debugging-tips)
- [Verbose logging](#verbose-logging)
- [Verbose logging](#verbose-logging)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

- [Crash logs](#crash-logs)
- [Terminal UI debugging](#terminal-ui-debugging)
- [Publishing `turbo` to the npm registry](#publishing-turbo-to-the-npm-registry)
Expand Down
3 changes: 2 additions & 1 deletion crates/turborepo-lib/src/run/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -262,8 +262,9 @@ impl Run {

let (sender, receiver) = TuiSender::new();
let color_config = self.color_config;
let repo_root = self.repo_root.clone();
chris-olszewski marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can just borrow here instead of cloning

Suggested change
let repo_root = self.repo_root.clone();
let repo_root = &self.repo_root;

let handle = tokio::task::spawn(async move {
Ok(tui::run_app(task_names, receiver, color_config).await?)
Ok(tui::run_app(task_names, receiver, color_config, &repo_root).await?)
});

Ok(Some((sender, handle)))
Expand Down
Loading
Loading