Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mfe): enable proxy for no turbo json #9560

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

chris-olszewski
Copy link
Member

Description

This PR adds the MFE support for repositories that do not contain a turbo.json. All this boils down to is:

  • Slight refactor for constructing MFE configs to allow for us to test this without hitting disk
  • Going down the "no turbo.json" codepath even if not explicitly enabled as long as MFE configs are present
  • Update generated turbo.json with proxy tasks injected

Testing Instructions

Added unit test for sans-turbo.json, but containing a MFE config.

Manual test on a MFE test repo w/o a turbo.json

@chris-olszewski chris-olszewski marked this pull request as ready for review December 4, 2024 16:31
@chris-olszewski chris-olszewski requested a review from a team as a code owner December 4, 2024 16:31
Copy link

vercel bot commented Dec 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2024 4:31pm
8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Dec 4, 2024 4:31pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Dec 4, 2024 4:31pm
examples-gatsby-web ⬜️ Ignored (Inspect) Dec 4, 2024 4:31pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Dec 4, 2024 4:31pm
examples-native-web ⬜️ Ignored (Inspect) Dec 4, 2024 4:31pm
examples-svelte-web ⬜️ Ignored (Inspect) Dec 4, 2024 4:31pm
examples-tailwind-web ⬜️ Ignored (Inspect) Dec 4, 2024 4:31pm
examples-vite-web ⬜️ Ignored (Inspect) Dec 4, 2024 4:31pm

Copy link
Member

@tknickman tknickman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@chris-olszewski chris-olszewski enabled auto-merge (squash) December 4, 2024 17:09
@chris-olszewski chris-olszewski merged commit 917f30b into main Dec 4, 2024
41 checks passed
@chris-olszewski chris-olszewski deleted the olszewski/feat_mfe_enable_for_no_turbo_json branch December 4, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants