refactor(opts): remove config from opts #9562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
NicholasLYang
commented
Dec 4, 2024
| @@ -172,7 +172,7 @@ impl Default for CacheActions { | |||
| } | |||
| } | |||
|
|
|||
| #[derive(Clone, Debug, Default, PartialEq, Eq)] | |||
There was a problem hiding this comment.
I removed the Default impl here because we shouldn't automatically create a default, it should directly flow from config.
chris-olszewski
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the config field from
Optsentirely. I'm doing this because the config data already gets partially moved intoOpts, so by keeping the config around, we have multiple sources for the same data. NowOptsis the fully transformed, normalized config for a run.You can review this commit by commit if you like
Testing Instructions