fix(repository): honour handleTransparentWorkspaces setting in Yarn/Berry #9626
Conversation
turbo-orchestrator
bot
added
the
needs: triage
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@romanofski is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
|
Would appreciate some guidance whether an additional integration test would be welcome. |
romanofski
force-pushed
the
fix/handleTransparentWorkspaces
branch
from
d183f26 to
7cb26de
Compare
There was a problem hiding this comment.
Thank you so much for the PR! This looks really good. I made some minor changes/code moving in romanofski#1. Feel free to merge it in or I can do it in a follow up PR.
Only thing blocking right now is fixing the default logic when parsing an yarnrc that doesn't have an enableTransparentWorkspaces field.
Would appreciate some guidance whether an additional integration test would be welcome.
For this case I think we have enough unit test coverage that adding an integration test isn't necessary.
| assert_eq!( | ||
| empty, | ||
| YarnRc { | ||
| enableTransparentWorkspaces: true |
There was a problem hiding this comment.
This currently fails as the serde definition requires this field to be present. To make it optional you can either:
- change the type to
Option<bool> - add
#[serde(default = default_fn)]to the field: docs
There was a problem hiding this comment.
Thanks again @chris-olszewski - learned something. Also for the improvements. Was able to learn from them too :)
chris-olszewski
removed
the
needs: triage
turbo-orchestrator
bot
added
the
needs: triage
chris-olszewski
removed
the
needs: triage
turbo-orchestrator
bot
added
the
needs: triage
romanofski
force-pushed
the
fix/handleTransparentWorkspaces
branch
from
979fbe1 to
7cb26de
Compare
romanofski
force-pushed
the
fix/handleTransparentWorkspaces
branch
from
7dbad5d to
00f40b6
Compare
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
1 similar comment
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
Description
This implements a fix for #8989 to honour
enableTransparentWorkspacesin a yarn config.The patch folds the config setting into the existing
link_workspace_packagesnpm settings as they're equivalent.Massive Kudos to @me4502 as she helped throughout the implementation process with testing and figuring things out.
Testing Instructions
a:turborepo/target/debug/turbo build --force --skip-infer --no-daemon --filter a