fs.exists is deprecated

[juanpicado]

My reason:

We use fs.exists at least twice in our source code, this has been deprecated, we should upgrade it.

https://nodejs.org/api/fs.html#fs_fs_exists_path_callback

[shrirambalaji]

@juanpicado I'd like to take a dig at this issue.

[juanpicado]

It's booked then :-)

[shrirambalaji]

@juanpicado The memory-fs library we are using doesn't seem to have an fs.access method. Although it has fs.stat, node docs don't seem recommend it:

Using fs.stat() to check for the existence of a file before calling fs.open(), fs.readFile() or fs.writeFile() is not recommended. Instead, user code should open/read/write the file directly and handle the error raised if the file is not available.

To check if a file exists without manipulating it afterwards, fs.access() is recommended.

Also, the library itself hasn't been updated in a while, so the chances of an upstream fix seem to be minimal.

Do you have a suggestion on what should be done? As mentioned, we could handle error the directly in the try-catch block without checking for the file's existence.

Or, If we should be using a different library,memfs looks like a good alternative.

[juanpicado]

Here you can find some inspiration verdaccio/local-storage#174

[shrirambalaji]

@juanpicado Thanks for the pointers. I have a PR up for review :)

[DanielRuf]

existsSync is not deprecated afaik.

https://nodejs.org/api/fs.html#fs_fs_existssync_path

[DanielRuf]

Also it was deprecated since NodeJS 1.0.0

[DanielRuf]

fs.exists() is deprecated, but fs.existsSync() is not. The callback parameter to fs.exists() accepts parameters that are inconsistent with other Node.js callbacks. fs.existsSync() does not use a callback.

[DanielRuf]

See https://nodejs.org/docs/latest-v4.x/api/fs.html#fs_fs_exists_path_callback ;-)

[juanpicado]

FYI #159

[DanielRuf]

I already saw it and gave feedback there ;-)