Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy support #86

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Proxy support #86

wants to merge 2 commits into from

Conversation

scopatz
Copy link

@scopatz scopatz commented May 30, 2019

This builds off of (and includes) @816-8055's work in #79 to enable proxy and insecure support.

If there is anything else that needs to happe here, please let me know!

@codecov-io
Copy link

codecov-io commented May 30, 2019

Codecov Report

Merging #86 into master will decrease coverage by 2.35%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #86      +/-   ##
==========================================
- Coverage   92.11%   89.76%   -2.36%     
==========================================
  Files           2        2              
  Lines         279      293      +14     
==========================================
+ Hits          257      263       +6     
- Misses         22       30       +8
Impacted Files Coverage Δ
conda_mirror/conda_mirror.py 89.65% <60%> (-2.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3fdfb1...30a421f. Read the comment docs.

@scopatz
Copy link
Author

scopatz commented May 31, 2019

pinging this @parente (since you seem to be the current maintainer)

Copy link
Contributor

@parente parente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scopatz Thanks for the PR. I'm not employed by ValDig anymore, so I'm not sure if someone there would like to have a look before merging or not. Let me see if I can get in touch with someone.

@scopatz
Copy link
Author

scopatz commented Jun 3, 2019

Oh, OK. So is this project unmaintained? Thanks for reaching out to them!

@parente
Copy link
Contributor

parente commented Jun 3, 2019

So is this project unmaintained?

It's been best effort maintenance for a couple years. Maybe it makes sense to see if it should live in a conda org somewhere? Not sure if there's a conflict of interest with the Anaconda product suite.

@dharhas
Copy link

dharhas commented Jun 3, 2019

I think it makes more sense as a community project, maybe under the conda-forge umbrella.

@scopatz
Copy link
Author

scopatz commented Jun 3, 2019

Yeah, I think that a community project for this would be best. conda-forge (and its sub-org, regro) would probably be willing to accept it. Would @Valassis-Digital-Media be willing to transfer ownership of the repo?

@scopatz
Copy link
Author

scopatz commented Jun 4, 2019

Actually, conda-forge is probably uninterested in supporting conda-mirror going forward. Is there a way some other folks (myself included) could get commit rights? Or maybe another org would be willing to take on maintainence?

@scopatz
Copy link
Author

scopatz commented Jun 6, 2019

Pinging this again. It would be great if some of us from the community could get access to help with maintainence.

@parente
Copy link
Contributor

parente commented Jun 6, 2019

@scopatz I have an email out to mgmt at ValassisDigital.

@scopatz
Copy link
Author

scopatz commented Jun 6, 2019

Ahh great! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants