-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: Hierarchical System Properties #130
Enhancement: Hierarchical System Properties #130
Conversation
can you document this in the index.adoc file ? also I think we should change the hierarchical name to rather something that mentions that now qualified names are accepted. |
vertx-config/src/test/java/io/vertx/config/impl/spi/SystemPropertiesConfigStoreTest.java
Show resolved
Hide resolved
I added the documentation and also added some assertions to the test cases. The test now asserts that the properties are indeed parsed to a flat object when
In my opinion, |
vertx-config/src/main/java/io/vertx/config/spi/utils/JsonObjectHelper.java
Outdated
Show resolved
Hide resolved
I see the check is failing, but that doesn't seem to be related with my changes. There's some test failing in the |
ok @Traderjoe95 |
I will check locally the tests |
I fixed the spring config cloud server issues in the CI |
the current vault failures are due to https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8266261 |
can you rebase and force push on latest master ? now tests should pass |
ping @Traderjoe95 |
Otherwise the Vert.x stack convergence tests fail (conflict with Cassandra Client)
0f93be1
to
98175d9
Compare
Hey, sorry it looks like I accidentally destroyed the history when rebasing. I will try to fix it |
Okay, the commits are back. Do you want me to clean up the history or is the merge commit fine? |
@Traderjoe95 if you can squash commits and sign the ECA, it would be great |
Of course, will do. Regarding the ECA, I already signed it. The failure is related to one of the commits I pulled in from master |
Also adds tests and documentation Signed-off-by: Johannes Leupold <johannes.leupold@kobil.com>
be522ad
to
d4b78a1
Compare
...onfig-spring-config-server/src/main/java/io/vertx/config/spring/SpringConfigServerStore.java
Show resolved
Hide resolved
can you provide a new PR created from master on which you cherry-pick your commits only ? |
Sure, I will create a new one during the day |
Closed in favor of #135 |
Fixes #129