Bug fix from 3.6.4 missing in 3.7 #84
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hierarchical properties file processor thows a ArrayIndexOutOfBoundsException when file contains comments or blank lines. The fix was to filter blank lines and lines starting with either "#" or "!" (after triming spaces) in the toJson method. The patch was merged into 3.6.4 but I've been requested by Juilen to PR the patch into 3.7
I've updated the hierarchical.properties to include comments (with both "#" and "!") and blank lines in order to test the bug fix for hierarchical processor throwing an exception when having properties file with comments and/or blank lines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by Juilent I created a new PR with a bugfix from 3.6.4