Support untyped enum declaration #902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taichi-ishitani
force-pushed
the
typeless_enum
branch
3 times, most recently
from
982fb8b to
369d3f7
Compare
dalance
reviewed
Aug 22, 2024
| } else { | ||
| // TODO: | ||
| // report error | ||
| unreachable!(); |
There was a problem hiding this comment.
Generally unreachable! is used for "this statement is unreachable logically".
If reporting error is required in the future, todo!("report error"); is better.
| @@ -626,6 +662,8 @@ impl<'a> VerylGrammarTrait for CreateSymbolTable<'a> { | |||
| if let Some(namespace) = namespace { | |||
| self.namespace.push(namespace); | |||
| } | |||
|
|
|||
| self.enum_member_value = Some(value.clone()); | |||
There was a problem hiding this comment.
clone is not required because value is not used after this statement.
crates/analyzer/src/symbol.rs
Outdated
| @@ -458,12 +458,16 @@ impl fmt::Display for SymbolKind { | |||
| format!("typedef alias ({})", x.r#type) | |||
| } | |||
| SymbolKind::Enum(x) => { | |||
| format!("enum ({})", x.r#type) | |||
| if x.r#type.is_some() { | |||
There was a problem hiding this comment.
Using if let Some is more idiomatic.
if let Some(ref x) = x.r#type {
format!("enum ({})", x)
} else {
crates/emitter/src/emitter.rs
Outdated
|
|
||
| fn default_enum_type(&mut self, arg: &EnumDeclaration) { | ||
| let enum_symbol = symbol_table::resolve(arg.identifier.as_ref()) | ||
| .unwrap() |
There was a problem hiding this comment.
This unwrap may be troublesome.
If there is any error around symbol table, this resolve may be failed.
So Veryl compiler may panic before reporting these errors.
crates/emitter/src/emitter.rs
Outdated
| if let SymbolKind::EnumMember(member) = member_symbol.kind { | ||
| match member.value { | ||
| EnumMemberValue::ExplicitValue(_expression, evaluated) => { | ||
| if evaluated.is_some() && evaluated.unwrap() > max_value { |
There was a problem hiding this comment.
Could you use if let Some?
taichi-ishitani
force-pushed
the
typeless_enum
branch
from
369d3f7 to
e61e5ef
Compare
|
I fixed all review feedbacks. |
taichi-ishitani
force-pushed
the
typeless_enum
branch
from
e61e5ef to
10136e9
Compare
|
Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #539