This repository has been archived by the owner on Dec 1, 2022. It is now read-only.
Return all rules when execution plan is not stable #1085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aiee
changed the title
monadbobo
reviewed
May 27, 2021
| @@ -28,6 +28,16 @@ OptGroup *OptGroup::create(OptContext *ctx) { | |||
| return ctx->objPool()->add(new OptGroup(ctx)); | |||
| } | |||
|
|
|||
| void OptGroup::setUnexplored(const OptRule *rule) { | |||
| auto iter = std::find(exploredRules_.begin(), exploredRules_.end(), rule); | |||
There was a problem hiding this comment.
Here you can directly use std::erase+std::remove_if
yixinglu
changed the title
czpmango
previously approved these changes
Jun 16, 2021
|
|
Fix unexplore of group node Rename
yixinglu
requested review from
czpmango,
jievince,
Aiee,
CPWstatic and
laura-ding
Aiee
changed the title
Aiee
approved these changes
Jul 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as title