This repository has been archived by the owner on Dec 1, 2022. It is now read-only.
get subgraph no prop #1134
Merged
get subgraph no prop #1134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shylock-Hg
reviewed
Jun 15, 2021
| @@ -10,86 +10,86 @@ Feature: Integer Vid subgraph | |||
| Scenario: Integer Vid invalid input | |||
| When executing query: | |||
| """ | |||
| GET SUBGRAPH FROM $-.id | |||
| GET SUBGRAPH WITH PROP FROM $-.id | |||
There was a problem hiding this comment.
It's incompatible. Why don't try without prop?
There was a problem hiding this comment.
To be consistent with the path sentence
yixinglu
previously approved these changes
Jun 15, 2021
Shylock-Hg
added
the
incompatible
Shylock-Hg
reviewed
Jun 15, 2021
| @@ -241,16 +245,20 @@ Status GetSubgraphValidator::toPlan() { | |||
| return Status::OK(); | |||
| } | |||
|
|
|||
| StatusOr<std::vector<storage::cpp2::VertexProp>> GetSubgraphValidator::buildVertexProp() { | |||
| StatusOr<GetNeighbors::VertexProps> GetSubgraphValidator::buildVertexProp() { | |||
There was a problem hiding this comment.
I think you could reuse SchemaUtil::getAllVertexProp function.
There was a problem hiding this comment.
Will be refactored in other pr, move it to planner
|
has AddressSanitizer error, solve it first. |
laura-ding
approved these changes
Jun 15, 2021
laura-ding
added
the
doc affected
yixinglu
approved these changes
Jun 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.