This repository has been archived by the owner on Dec 1, 2022. It is now read-only.
Fix permission when use multi sentences with use space #1165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laura-ding
added
ready-for-testing
yixinglu
reviewed
Jun 23, 2021
src/validator/UseValidator.cpp
Outdated
| auto switchSpace = SwitchSpace::make(qctx_, | ||
| nullptr, | ||
| *spaceName_, | ||
| qctx_->rctx()->session()->space()); |
There was a problem hiding this comment.
Do we still need to save old space in this plan node ?
yixinglu
approved these changes
Jun 24, 2021
yixinglu
requested review from
Shylock-Hg,
CPWstatic,
czpmango,
jievince and
nevermore3
bright-starry-sky
approved these changes
Jun 25, 2021
This was referenced Jun 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1109