Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support to set headers for http2 #548

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Conversation

Nicole00
Copy link
Contributor

close #547

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 57.50% and project coverage change: -0.06% ⚠️

Comparison is base (d8701fe) 62.98% compared to head (4878757) 62.92%.
Report is 1 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #548      +/-   ##
============================================
- Coverage     62.98%   62.92%   -0.06%     
- Complexity      801      802       +1     
============================================
  Files            72       72              
  Lines          3942     3960      +18     
  Branches        539      539              
============================================
+ Hits           2483     2492       +9     
- Misses         1089     1097       +8     
- Partials        370      371       +1     
Files Changed Coverage Δ
...com/vesoft/nebula/client/graph/net/Connection.java 100.00% <ø> (ø)
...vesoft/nebula/client/graph/net/SyncConnection.java 49.37% <35.71%> (+0.67%) ⬆️
...m/vesoft/nebula/client/graph/NebulaPoolConfig.java 91.11% <50.00%> (-4.02%) ⬇️
.../vesoft/nebula/client/graph/SessionPoolConfig.java 49.46% <50.00%> (+0.02%) ⬆️
...va/com/vesoft/nebula/client/graph/SessionPool.java 51.58% <66.66%> (-0.93%) ⬇️
...ebula/client/graph/net/RoundRobinLoadBalancer.java 84.84% <71.42%> (+0.23%) ⬆️
...vesoft/nebula/client/graph/net/ConnObjectPool.java 58.13% <100.00%> (+0.99%) ⬆️
...com/vesoft/nebula/client/graph/net/NebulaPool.java 86.40% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@wenhaocs wenhaocs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's amazing to find that you've created the setCustomHeaders interface in advance. Well done. Let's wait for other Java folks to review the PR.

if (isUseHttp2) {
this.useHttp2 = isUseHttp2;
this.headers = headers;
if (useHttp2) {
getProtocolForHttp2();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

headers are only for useHttp2=true, only used for HTTPClient
prefer getProtocolForHttp2(headers); and do not use this.headers

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reopen will use headers when useHttp2 is true, need a global var to save the info.

@Nicole00 Nicole00 merged commit 12452cb into vesoft-inc:master Sep 15, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow users to setHeader when using HTTP/2
4 participants