Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/coverage #1410

Closed
wants to merge 70 commits into from
Closed

Feature/coverage #1410

wants to merge 70 commits into from

Conversation

Shylock-Hg
Copy link
Contributor

@Shylock-Hg Shylock-Hg commented Dec 10, 2019

Ok. Require #1401 or Out-Of-Disk in action
Ok. Require enable codecov and provide the CODECOV_TOKEN environment in action
Require codecov/codecov-action#29, the secrets can't access by the user without write permission. Maybe we need 1. use the raw token 2. waiting the workaround.
Refer to https://stackoverflow.com/questions/58737785/github-actions-empty-env-secrets

@Shylock-Hg
Copy link
Contributor Author

Tried ok in local reporting.

@dangleptr
Copy link
Contributor

What's the reporting looks like? Could you post a picture for that?

@Shylock-Hg
Copy link
Contributor Author

What's the reporting looks like? Could you post a picture for that?

https://codecov.io/gh/Shylock-Hg/nebula/commits

@Shylock-Hg Shylock-Hg added the ready-for-testing PR: ready for the CI test label Jan 1, 2020
@nebula-community-bot
Copy link
Member

Unit testing failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants