Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/coverage action #1856

Merged
merged 16 commits into from
Mar 9, 2020
Merged

Feature/coverage action #1856

merged 16 commits into from
Mar 9, 2020

Conversation

Shylock-Hg
Copy link
Contributor

What changes were proposed in this pull request?

Migrate coverage to github action.

Why are the changes needed?

For testing coverage

Does this PR introduce any user-facing change?

How was this patch tested?

@Shylock-Hg
Copy link
Contributor Author

Require vesoft-inc/nebula-dev-docker#36

@Shylock-Hg
Copy link
Contributor Author

Replace #1704

@Shylock-Hg Shylock-Hg added the ready-for-testing PR: ready for the CI test label Mar 4, 2020
@Shylock-Hg
Copy link
Contributor Author

Shylock-Hg commented Mar 4, 2020 •
edited
Loading

Mark need more memory for coverage compiling with all cpu core work.

@Shylock-Hg
Copy link
Contributor Author

Shylock-Hg commented Mar 4, 2020 •
edited
Loading

Mark , the lcov process time consumption is much more Unusually Large than previous version.

@codecov-io
Copy link

codecov-io commented Mar 4, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@cee3402). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1856   +/-   ##
=========================================
  Coverage          ?   86.66%           
=========================================
  Files             ?      616           
  Lines             ?    57879           
  Branches          ?        0           
=========================================
  Hits              ?    50162           
  Misses            ?     7717           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cee3402...393d8e3. Read the comment docs.

@jude-zhu jude-zhu added this to the R201910_RC4 milestone Mar 5, 2020
yixinglu
yixinglu previously approved these changes Mar 5, 2020
View reviewed changes
monadbobo
monadbobo previously approved these changes Mar 5, 2020
View reviewed changes
Copy link
Contributor

@monadbobo monadbobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dangleptr
Copy link
Contributor

Excellent

@Shylock-Hg Shylock-Hg dismissed stale reviews from monadbobo and yixinglu via 9abfd52 March 6, 2020 04:36
monadbobo
monadbobo approved these changes Mar 6, 2020
View reviewed changes
Copy link
Contributor

@monadbobo monadbobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dangleptr
Copy link
Contributor

It seems current make process run more slowly than before. Please check it again.

@Shylock-Hg
Copy link
Contributor Author

It seems current make process run more slowly than before. Please check it again.

It's fault of lcov.I think won't affect the building and testing.

@dutor dutor merged commit fdeed62 into vesoft-inc:master Mar 9, 2020
@Shylock-Hg Shylock-Hg mentioned this pull request Mar 9, 2020
Closed
@jude-zhu
Copy link
Contributor

close #968

tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
@Shylock-Hg @dangleptr
Feature/coverage action (vesoft-inc#1856)
11472d2 
* Collect coverage in azure pipelines which not require token for codecov.io.

* Add azure-pipelines.yml

* Remove the library coverage information.

* Add coverage badge.

* Let action run coverage report.

* Try less avoid OOM.

* Revert "Try less avoid OOM."

This reverts commit 94fb05c.

* Limit the coverage building concurrency.

* Fix the logic.

Co-authored-by: dangleptr <37216992+dangleptr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monadbobo monadbobo monadbobo approved these changes

@yixinglu yixinglu yixinglu approved these changes

@laura-ding laura-ding Awaiting requested review from laura-ding

@dutor dutor Awaiting requested review from dutor

Assignees
No one assigned
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
R201910_RC4
Development

Successfully merging this pull request may close these issues.
7 participants
@Shylock-Hg @codecov-io @dangleptr @jude-zhu @monadbobo @yixinglu @dutor