Fix/fix #3570
Merged
Fix/fix #3570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shylock-Hg
added
ready-for-testing
Aiee
reviewed
Dec 28, 2021
| @@ -18,6 +18,7 @@ namespace nebula { | |||
| std::shared_ptr<wangle::SSLContextConfig> sslContextConfig() { | |||
| auto sslCfg = std::make_shared<wangle::SSLContextConfig>(); | |||
| sslCfg->addCertificate(FLAGS_cert_path, FLAGS_key_path, FLAGS_password_path); | |||
| sslCfg->clientVerification = folly::SSLContext::VerifyClientCertificate::DO_NOT_REQUEST; | |||
There was a problem hiding this comment.
Does this mean that the certificate from the client could be omitted?
There was a problem hiding this comment.
how about using "always" and failed if verification fails
There was a problem hiding this comment.
Not, it just check CA of server (which is new feature after library upgrading), so I disable it to keep same with before.
HarrisChu
previously approved these changes
Dec 28, 2021
HarrisChu
added
incompatible
Aiee
previously approved these changes
Dec 28, 2021
Aiee
approved these changes
Dec 28, 2021
HarrisChu
approved these changes
Dec 28, 2021
Could you detail this proposal? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do?
Fit the library ssl configuration upgrading.
Need #3471 , seems don't support plaintext in ssl port again.
Which issue(s)/PR(s) this PR relates to?
Special notes for your reviewer, ex. impact of this fix, etc:
Additional context/ Design document:
Checklist:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: