Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arnej/unify cluster names #1579

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

arnej27959
Copy link
Member

@radu-gheorghe please review
note that this copies the part-purchase-demo app into ch3, with minor adjustments, so that would need an update of the Lab instructions.
The extra "token" endpoint variant is problematic, and not something we want to cover in the 101 Lab lessons, so I put that inside comments.

Copy link
Contributor

@radu-gheorghe radu-gheorghe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks! I left a small comment, but my testing went through nicely as it is now.

I'll adjust the labs.

</nodes>
</container>

<content version="1.0">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need "content" here as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants